Re: [Qemu-devel] [patch] add byteordered types

[Gerd Hoffmann <kraxel@redhat.com>]

M. Warner Losh wrote:
> In message: <48B56645.60206@redhat.com>
>             Gerd Hoffmann <kraxel@redhat.com> writes:
> : Paul Brook wrote:
> : > On Wednesday 27 August 2008, Gerd Hoffmann wrote:
> : >> +static inline le16 write_le16(uint16_t cpu) \
> : > 
> : > This is IMHO a bad name for this function. It doesn't write anything.
> : 
> : I'm not that happy the name too and certainly open for better
> : suggestions I could use instead of read/write.
> : 
> : The alternatives I can think of are not very nice either:
> : 
> :  (1) get/set -- same problem as read/write.
> :  (2) make_foo() instead of write_foo() -- "make" is too generic IMHO.
> :  (3) create_foo() instead of write_foo() -- no nice symmetric
> :      replacement for read_foo().
> : 
> : better ideas anyone?
> 
> Using the existing names that linux/FreeBSD/NetBSD/OpenBSD are using?

cpu_to_* is taken already by the not-typechecked macros.  And converting
the whole qemu tree in one go so we could reuse the names is a bit
unrealistic IMHO.

cheers,
  Gerd