[Patch] RFC: add LANG=C in stubdom's Makefile

[Patch] RFC: add LANG=C in stubdom's Makefile

[Akio Takebe]

[-- Attachment #1: Type: text/plain, Size: 2023 bytes --]

Hi,

I got a compile error of stubdom.
My environment is LANG=ja_JP.UTF-8,
and "gcc -print-search-dirs" prints Japanese messase.

[e.g.]
# echo $LANG
ja_JP.UTF-8
#  gcc -print-search-dirs
インストール: /usr/lib/gcc/i386-redhat-linux/4.3.0/
プログラム: =/usr/libexec/gcc/i386-redhat-linux/4.3.0/:/usr/libexec/gcc/i386-redhat-linux/4.3.0/:/usr/libexec/gcc/i386-redhat-linux/:/usr/lib/gcc/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/:/usr/libexec/gcc/i386-redhat-linux/4.3.0/:/usr/libexec/gcc/i386-redhat-linux/:/usr/lib/gcc/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../../i386-redhat-linux/bin/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../../i386-redhat-linux/bin/
ライブラリ: =/usr/lib/gcc/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../../i386-redhat-linux/lib/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../../i386-redhat-linux/lib/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../:/lib/i386-redhat-linux/4.3.0/:/lib/:/usr/lib/i386-redhat-linux/4.3.0/:/usr/lib/

So shell command of stubdom's Makefile doesn't work.
I made a patch for Japanese people. :)
How about it?

Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>

Best Regards,

Akio Takebe

diff -r 6c50c7d089d9 stubdom/Makefile
--- a/stubdom/Makefile	Wed Aug 27 15:16:13 2008 +0100
+++ b/stubdom/Makefile	Thu Aug 28 17:10:38 2008 +0900
@@ -53,7 +53,7 @@
 TARGET_CFLAGS += $(call cc-option,$(CC),-fno-stack-protector-all,)

 # Do not use host headers and libs
-GCC_INSTALL = $(shell gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
+GCC_INSTALL = $(shell LANG=C gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
 TARGET_CPPFLAGS += -U __linux__ -U __FreeBSD__ -U __sun__
 TARGET_CPPFLAGS += -nostdinc
 TARGET_CPPFLAGS += -isystem $(CURDIR)/$(MINI_OS)/include/posix


[-- Attachment #2: fix_compile_error_of_stubdom.patch --]
[-- Type: text/x-diff, Size: 598 bytes --]

diff -r 6c50c7d089d9 stubdom/Makefile
--- a/stubdom/Makefile	Wed Aug 27 15:16:13 2008 +0100
+++ b/stubdom/Makefile	Thu Aug 28 17:11:08 2008 +0900
@@ -53,7 +53,7 @@
 TARGET_CFLAGS += $(call cc-option,$(CC),-fno-stack-protector-all,)
 
 # Do not use host headers and libs
-GCC_INSTALL = $(shell gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
+GCC_INSTALL = $(shell LANG=C gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
 TARGET_CPPFLAGS += -U __linux__ -U __FreeBSD__ -U __sun__
 TARGET_CPPFLAGS += -nostdinc
 TARGET_CPPFLAGS += -isystem $(CURDIR)/$(MINI_OS)/include/posix

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [Patch] RFC: add LANG=C in stubdom's Makefile

[Samuel Thibault]

Akio Takebe, le Thu 28 Aug 2008 17:14:20 +0900, a écrit :
> # echo $LANG
> ja_JP.UTF-8
> #  gcc -print-search-dirs
> インストール: /usr/lib/gcc/i386-redhat-linux/4.3.0/

Argl, so that part is localized actually... (it is not translated in the
french locale).

> diff -r 6c50c7d089d9 stubdom/Makefile
> --- a/stubdom/Makefile	Wed Aug 27 15:16:13 2008 +0100
> +++ b/stubdom/Makefile	Thu Aug 28 17:10:38 2008 +0900
> @@ -53,7 +53,7 @@
>  TARGET_CFLAGS += $(call cc-option,$(CC),-fno-stack-protector-all,)
> 
>  # Do not use host headers and libs
> -GCC_INSTALL = $(shell gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
> +GCC_INSTALL = $(shell LANG=C gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
>  TARGET_CPPFLAGS += -U __linux__ -U __FreeBSD__ -U __sun__
>  TARGET_CPPFLAGS += -nostdinc
>  TARGET_CPPFLAGS += -isystem $(CURDIR)/$(MINI_OS)/include/posix

Should be fine.

Samuel