[U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

[U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

[vgallardo at amcc.com]

From: Victor Gallardo <vgallardo@amcc.com>


Signed-off-by: Victor Gallardo <vgallardo@amcc.com>
---
 cpu/ppc4xx/uic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpu/ppc4xx/uic.c b/cpu/ppc4xx/uic.c
index 7944c6c..a95d1cb 100644
--- a/cpu/ppc4xx/uic.c
+++ b/cpu/ppc4xx/uic.c
@@ -129,11 +129,11 @@ void external_interrupt(struct pt_regs *regs)
 		uic_interrupt(UIC3_DCR_BASE, 96);
 #endif
 
+	mtdcr(uic0sr, (uic_msr & UICB0_ALL));
+
 	if (uic_msr & ~(UICB0_ALL))
 		uic_interrupt(UIC0_DCR_BASE, 0);
 
-	mtdcr(uic0sr, uic_msr);
-
 	return;
 }
 
-- 
1.5.5

[U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

[Wolfgang Denk]

Dear vgallardo at amcc.com,

Can you please provide a real name with your mail address when
submitting patches?


In message <1219956791-5783-1-git-send-email-vgallardo@amcc.com> you wrote:

> Subject: [U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

This is an awfully long subject line.

As you are probably aware, the Subject line will be used as  part  of
the git commit message, and it will be shown as "title" of your patch
by tools like "git log" or "gitk" etc.

However, these tools will truncate the line after 70 characters. That
means, your commit message will read:

commit ...
Author: <vgallardo@amcc.com>
Date:   ...

    ppc4xx: fix UIC hang if critical or non-critical interrupt is set at


This is not exactly useful, is it?


So please use SHORT subject lines and provide the explanation in the
message body.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Alles Gescheite ist schon gedacht worden, man mu? nur versuchen,
es noch einmal zu denken.          -- Goethe, Maximen und Reflexionen

[U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

[Feng Kan]

Hi Wolfgang:
      I send the patch out for Victor. In the original email the From 
field did indicate his name.
Am I missing something?

Thanks
Feng Kan
> Dear vgallardo at amcc.com,
>
> Can you please provide a real name with your mail address when
> submitting patches?
>
>
>   

[U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

[Wolfgang Denk]

Dear Feng Kan,

In message <48B72323.4050608@amcc.com> you wrote:

>       I send the patch out for Victor. In the original email the From 
> field did indicate his name.
> Am I missing something?

I don't know what you did, but there were actually two semi-identical
postings:

------
Subject: [U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or
	non-critical interrupt is set at the same time as a normal
	interrupt is set on UIC0
From: vgallardo@amcc.com
Date: Thu, 28 Aug 2008 13:53:11 -0700 (22:53 MEST)
To: u-boot at lists.denx.de
Cc: sr at denx.de
------
Subject: [U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or
	non-critical interrupt is set at the same time as a normal
	interrupt is set on UIC0
From: fkan@amcc.com
Date: Thu, 28 Aug 2008 13:55:14 -0700 (22:55 MEST)
To: u-boot at lists.denx.de
Cc: sr at denx.de
------

As you can see, both were sent about two minutes apart, and  none  of
them had a realname in the From: field.

See also
http://lists.denx.de/pipermail/u-boot/2008-August/039566.html and
http://lists.denx.de/pipermail/u-boot/2008-August/039567.html

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As long as we're going to reinvent the wheel again, we might as  well
try making it round this time.                        - Mike Dennison

[U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

[fkan at amcc.com]

From: Victor Gallardo <vgallardo@amcc.com>


Signed-off-by: Victor Gallardo <vgallardo@amcc.com>
---
 cpu/ppc4xx/uic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpu/ppc4xx/uic.c b/cpu/ppc4xx/uic.c
index 7944c6c..a95d1cb 100644
--- a/cpu/ppc4xx/uic.c
+++ b/cpu/ppc4xx/uic.c
@@ -129,11 +129,11 @@ void external_interrupt(struct pt_regs *regs)
 		uic_interrupt(UIC3_DCR_BASE, 96);
 #endif
 
+	mtdcr(uic0sr, (uic_msr & UICB0_ALL));
+
 	if (uic_msr & ~(UICB0_ALL))
 		uic_interrupt(UIC0_DCR_BASE, 0);
 
-	mtdcr(uic0sr, uic_msr);
-
 	return;
 }
 
-- 
1.5.5