All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Handlers
Date: Fri, 29 Aug 2008 17:58:06 +0300	[thread overview]
Message-ID: <48B80E7E.1070300@nic.fi> (raw)
In-Reply-To: <87d4jsgfpz.fsf@xs4all.nl>

Marco Gerards wrote:
> This patch adds handler support to GRUB 2.  This makes it easier to
> add new handlers to GRUB without duplicating code over and over.  Bean
> wanted this for some of his ideas :-)
> 
> Okuji (and others), can you please review this patch?  It is an
> intrusive (but yet small!) change of which I hope most people agree
> with.  I just don't want to commit this without proper review.

Hi,

Just from previous experience with macros... it dam hard to debug with
them when you are using debugger. SO... if you can avoid that please do
it that way. Can you try to think alternative version without using macros?

Thanks,
Vesa Jääskeläinen



  parent reply	other threads:[~2008-08-29 14:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29 12:36 Handlers Marco Gerards
2008-08-29 13:27 ` Handlers Neal H. Walfield
2008-08-29 14:46   ` Handlers Marco Gerards
2008-08-29 19:13     ` Handlers Neal H. Walfield
2008-08-29 14:58 ` Vesa Jääskeläinen [this message]
2008-08-29 15:10   ` Handlers Marco Gerards
2008-08-29 19:43     ` Handlers Vesa Jääskeläinen
2008-08-30  1:27       ` Handlers Marco Gerards
2008-08-30 14:55         ` Handlers Vesa Jääskeläinen
2008-08-30 12:45 ` Handlers Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B80E7E.1070300@nic.fi \
    --to=chaac@nic.fi \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.