All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] The commented line in udev-test.pl to use valgrind needs
@ 2008-08-31 17:25 Alan Jenkins
  2008-09-01 14:29 ` [PATCH] The commented line in udev-test.pl to use valgrind needs fixing Kay Sievers
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Alan Jenkins @ 2008-08-31 17:25 UTC (permalink / raw)
  To: linux-hotplug

Also run with --quiet to show errors only.

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>

diff --git a/test/udev-test.pl b/test/udev-test.pl
index ad551dd..6c51399 100755
--- a/test/udev-test.pl
+++ b/test/udev-test.pl
@@ -29,7 +29,7 @@ my $udev_rules	= "udev-test.rules";
 
 # uncomment following line to run udev with valgrind.
 # Should make this a runtime option to the script someday...
-#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
+#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";
 
 my @tests = (
 	{



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] The commented line in udev-test.pl to use valgrind needs fixing
  2008-08-31 17:25 [PATCH] The commented line in udev-test.pl to use valgrind needs Alan Jenkins
@ 2008-09-01 14:29 ` Kay Sievers
  2008-09-03 12:50 ` [PATCH] The commented line in udev-test.pl to use valgrind needs Alan Jenkins
  2008-09-03 20:02 ` [PATCH] The commented line in udev-test.pl to use valgrind needs fixing Kay Sievers
  2 siblings, 0 replies; 4+ messages in thread
From: Kay Sievers @ 2008-09-01 14:29 UTC (permalink / raw)
  To: linux-hotplug

On Sun, Aug 31, 2008 at 19:25, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
> Also run with --quiet to show errors only.
>
> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
>
> diff --git a/test/udev-test.pl b/test/udev-test.pl
> index ad551dd..6c51399 100755
> --- a/test/udev-test.pl
> +++ b/test/udev-test.pl
> @@ -29,7 +29,7 @@ my $udev_rules        = "udev-test.rules";
>
>  # uncomment following line to run udev with valgrind.
>  # Should make this a runtime option to the script someday...
> -#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
> +#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";

I've added a --valgrind option instead, so there is no longer the need
to change the source file.

Thanks,
Kay

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] The commented line in udev-test.pl to use valgrind needs
  2008-08-31 17:25 [PATCH] The commented line in udev-test.pl to use valgrind needs Alan Jenkins
  2008-09-01 14:29 ` [PATCH] The commented line in udev-test.pl to use valgrind needs fixing Kay Sievers
@ 2008-09-03 12:50 ` Alan Jenkins
  2008-09-03 20:02 ` [PATCH] The commented line in udev-test.pl to use valgrind needs fixing Kay Sievers
  2 siblings, 0 replies; 4+ messages in thread
From: Alan Jenkins @ 2008-09-03 12:50 UTC (permalink / raw)
  To: linux-hotplug

Kay Sievers wrote:
> On Sun, Aug 31, 2008 at 19:25, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>   
>> Also run with --quiet to show errors only.
>>
>> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
>>
>> diff --git a/test/udev-test.pl b/test/udev-test.pl
>> index ad551dd..6c51399 100755
>> --- a/test/udev-test.pl
>> +++ b/test/udev-test.pl
>> @@ -29,7 +29,7 @@ my $udev_rules        = "udev-test.rules";
>>
>>  # uncomment following line to run udev with valgrind.
>>  # Should make this a runtime option to the script someday...
>> -#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
>> +#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";
>>     
>
> I've added a --valgrind option instead, so there is no longer the need
> to change the source file.
>
> Thanks,
> Kay
>   
Ah, you forgot to remove this line though:

# uncomment following line to run udev with valgrind.

Alan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] The commented line in udev-test.pl to use valgrind needs fixing
  2008-08-31 17:25 [PATCH] The commented line in udev-test.pl to use valgrind needs Alan Jenkins
  2008-09-01 14:29 ` [PATCH] The commented line in udev-test.pl to use valgrind needs fixing Kay Sievers
  2008-09-03 12:50 ` [PATCH] The commented line in udev-test.pl to use valgrind needs Alan Jenkins
@ 2008-09-03 20:02 ` Kay Sievers
  2 siblings, 0 replies; 4+ messages in thread
From: Kay Sievers @ 2008-09-03 20:02 UTC (permalink / raw)
  To: linux-hotplug

On Wed, Sep 3, 2008 at 14:50, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
> Kay Sievers wrote:
>> On Sun, Aug 31, 2008 at 19:25, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>>
>>> Also run with --quiet to show errors only.
>>>
>>> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
>>>
>>> diff --git a/test/udev-test.pl b/test/udev-test.pl
>>> index ad551dd..6c51399 100755
>>> --- a/test/udev-test.pl
>>> +++ b/test/udev-test.pl
>>> @@ -29,7 +29,7 @@ my $udev_rules        = "udev-test.rules";
>>>
>>>  # uncomment following line to run udev with valgrind.
>>>  # Should make this a runtime option to the script someday...
>>> -#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
>>> +#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";
>>>
>>
>> I've added a --valgrind option instead, so there is no longer the need
>> to change the source file.
>>
>> Thanks,
>> Kay
>>
> Ah, you forgot to remove this line though:

Removed.

Thanks,
Kay

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-09-03 20:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-31 17:25 [PATCH] The commented line in udev-test.pl to use valgrind needs Alan Jenkins
2008-09-01 14:29 ` [PATCH] The commented line in udev-test.pl to use valgrind needs fixing Kay Sievers
2008-09-03 12:50 ` [PATCH] The commented line in udev-test.pl to use valgrind needs Alan Jenkins
2008-09-03 20:02 ` [PATCH] The commented line in udev-test.pl to use valgrind needs fixing Kay Sievers

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.