All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: xerces8 <xerces8@butn.net>
Cc: linux-ide@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
	stein@hermes.si
Subject: Re: Intel AHCI ICH9R not detecting devices
Date: Mon, 01 Sep 2008 11:13:44 +0200	[thread overview]
Message-ID: <48BBB248.7090904@kernel.org> (raw)
In-Reply-To: <WorldClient-F200808302142.AA42270030@butn.net>

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

xerces8 wrote:
>> This looks like resource conflict to me, which could have resulted
>> from ahci trying to grab all resources.  Can you please post the
>> result of "cat /proc/ioports" and "cat /proc/iomem"?
> 
> I noticed that in IDE mode the same happens (32bit kernel has problems,
> 64bit kernel has not), so here is dmesg, iomem and ioports for all 4
> combinations.

Can you please try the attached debug patch and report boot log.  All
resources look fine.

Thanks.

-- 
tejun

[-- Attachment #2: debug --]
[-- Type: text/plain, Size: 1872 bytes --]

---
 drivers/ata/ahci.c |   21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

Index: tree0/drivers/ata/ahci.c
===================================================================
--- tree0.orig/drivers/ata/ahci.c
+++ tree0/drivers/ata/ahci.c
@@ -2240,8 +2240,10 @@ static int ahci_init_one(struct pci_dev
 
 	/* acquire resources */
 	rc = pcim_enable_device(pdev);
-	if (rc)
+	if (rc) {
+		dev_printk(KERN_WARNING, &pdev->dev, "pcim_enable_device failed %d\n", rc);
 		return rc;
+	}
 
 	/* AHCI controllers often implement SFF compatible interface.
 	 * Grab all PCI BARs just in case.
@@ -2249,8 +2251,10 @@ static int ahci_init_one(struct pci_dev
 	rc = pcim_iomap_regions_request_all(pdev, 1 << AHCI_PCI_BAR, DRV_NAME);
 	if (rc == -EBUSY)
 		pcim_pin_device(pdev);
-	if (rc)
+	if (rc) {
+		dev_printk(KERN_WARNING, &pdev->dev, "pcim_iomap_regions_request_all() failed %d\n", rc);
 		return rc;
+	}
 
 	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
 	    (pdev->device == 0x2652 || pdev->device == 0x2653)) {
@@ -2324,19 +2328,26 @@ static int ahci_init_one(struct pci_dev
 
 	/* initialize adapter */
 	rc = ahci_configure_dma_masks(pdev, hpriv->cap & HOST_CAP_64);
-	if (rc)
+	if (rc) {
+		dev_printk(KERN_WARNING, &pdev->dev, "ahci_configure_dma_masks() failed %d\n", rc);
 		return rc;
+	}
 
 	rc = ahci_reset_controller(host);
-	if (rc)
+	if (rc) {
+		dev_printk(KERN_WARNING, &pdev->dev, "ahci_reset_controller() failed %d\n", rc);
 		return rc;
+	}
 
 	ahci_init_controller(host);
 	ahci_print_info(host);
 
 	pci_set_master(pdev);
-	return ata_host_activate(host, pdev->irq, ahci_interrupt, IRQF_SHARED,
+	rc = ata_host_activate(host, pdev->irq, ahci_interrupt, IRQF_SHARED,
 				 &ahci_sht);
+	if (rc)
+		dev_printk(KERN_WARNING, &pdev->dev, "ahci_host_activate() failed %d\n", rc);
+	return rc;
 }
 
 static int __init ahci_init(void)

  reply	other threads:[~2008-09-01  9:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-22 15:29 Intel AHCI ICH9R not detecting devices xerces8
2008-08-30 10:40 ` Tejun Heo
2008-08-30 19:42   ` xerces8
2008-09-01  9:13     ` Tejun Heo [this message]
2008-09-01 10:40       ` xerces8
2008-09-06 18:12       ` xerces8
2008-09-06 21:31         ` xerces8
2008-09-08 11:35           ` Tejun Heo
2008-09-08 11:43             ` xerces8
2008-09-08 11:54               ` Tejun Heo
2008-09-12  7:53                 ` xerces8
2008-09-12  8:38                   ` [PATCH] ide: note that IDE generic may prevent other drivers from attaching Tejun Heo
2008-09-27 17:13                     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BBB248.7090904@kernel.org \
    --to=tj@kernel.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=stein@hermes.si \
    --cc=xerces8@butn.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.