* [PATCH] hda: Distortion fix for dell_m6_core_init
@ 2008-08-31 18:53 Matthew Ranostay
2008-09-01 6:38 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Ranostay @ 2008-08-31 18:53 UTC (permalink / raw)
To: alsa-devel; +Cc: Takashi Iwai, Tellman, Steven
Added the EQ distortion fix to the dell_m6_core_init.
---
Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
index 6ad6ef3..9968ee4 100644
--- a/pci/hda/patch_sigmatel.c
+++ b/pci/hda/patch_sigmatel.c
@@ -606,8 +606,9 @@ static struct hda_verb dell_eq_core_init[] = {
};
static struct hda_verb dell_m6_core_init[] = {
- /* set master volume and direct control */
- { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff},
+ /* set master volume to max value without distortion
+ * and direct control */
+ { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xec},
/* setup audio connections */
{ 0x0d, AC_VERB_SET_CONNECT_SEL, 0x00},
{ 0x0a, AC_VERB_SET_CONNECT_SEL, 0x01},
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hda: Distortion fix for dell_m6_core_init
2008-08-31 18:53 [PATCH] hda: Distortion fix for dell_m6_core_init Matthew Ranostay
@ 2008-09-01 6:38 ` Takashi Iwai
2008-09-01 13:51 ` Matthew Ranostay
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2008-09-01 6:38 UTC (permalink / raw)
To: Matthew Ranostay; +Cc: alsa-devel, Tellman, Steven
At Sun, 31 Aug 2008 14:53:38 -0400,
Matthew Ranostay wrote:
>
> Added the EQ distortion fix to the dell_m6_core_init.
>
> ---
> Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
Thanks. I'll include this as 2.6.27 fixes, too.
BTW, I found the volume-knob on 0x1f is set to 0xff with other models
(e.g. intel boards). Don't you need to fix them as well?
Takashi
> diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
> index 6ad6ef3..9968ee4 100644
> --- a/pci/hda/patch_sigmatel.c
> +++ b/pci/hda/patch_sigmatel.c
> @@ -606,8 +606,9 @@ static struct hda_verb dell_eq_core_init[] = {
> };
>
> static struct hda_verb dell_m6_core_init[] = {
> - /* set master volume and direct control */
> - { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff},
> + /* set master volume to max value without distortion
> + * and direct control */
> + { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xec},
> /* setup audio connections */
> { 0x0d, AC_VERB_SET_CONNECT_SEL, 0x00},
> { 0x0a, AC_VERB_SET_CONNECT_SEL, 0x01},
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hda: Distortion fix for dell_m6_core_init
2008-09-01 6:38 ` Takashi Iwai
@ 2008-09-01 13:51 ` Matthew Ranostay
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Ranostay @ 2008-09-01 13:51 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
Takashi Iwai wrote:
> At Sun, 31 Aug 2008 14:53:38 -0400,
> Matthew Ranostay wrote:
>> Added the EQ distortion fix to the dell_m6_core_init.
>>
>> ---
>> Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
>
> Thanks. I'll include this as 2.6.27 fixes, too.
>
> BTW, I found the volume-knob on 0x1f is set to 0xff with other models
> (e.g. intel boards). Don't you need to fix them as well?
>
Nope, they don't have this issue.
>
> Takashi
>
>> diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
>> index 6ad6ef3..9968ee4 100644
>> --- a/pci/hda/patch_sigmatel.c
>> +++ b/pci/hda/patch_sigmatel.c
>> @@ -606,8 +606,9 @@ static struct hda_verb dell_eq_core_init[] = {
>> };
>>
>> static struct hda_verb dell_m6_core_init[] = {
>> - /* set master volume and direct control */
>> - { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff},
>> + /* set master volume to max value without distortion
>> + * and direct control */
>> + { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xec},
>> /* setup audio connections */
>> { 0x0d, AC_VERB_SET_CONNECT_SEL, 0x00},
>> { 0x0a, AC_VERB_SET_CONNECT_SEL, 0x01},
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-01 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-31 18:53 [PATCH] hda: Distortion fix for dell_m6_core_init Matthew Ranostay
2008-09-01 6:38 ` Takashi Iwai
2008-09-01 13:51 ` Matthew Ranostay
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.