All of lore.kernel.org
 help / color / mirror / Atom feed
* re /drivers/char/n_tty.c drops characters
@ 2008-09-03  8:32 Denis Joseph Barrow
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Joseph Barrow @ 2008-09-03  8:32 UTC (permalink / raw)
  To: linux-kernel, Filip Aben, Andrew Bird, Greg Kroah-Hartman,
	Jeff Garzik

Hi,
There are functions tty_throttle & tty_unthrottle
called from the n_tty line discipline, it might do everything
I want it to do.

I might be plain wrong & casting asparagus about my understanding of
the n_tty & it might not drop packets
in the latest kernel.

If I'm wrong about n_tty.c & being stupid thinking the n_tty layer 
drops packets please inform me & tell me why it doesn't.

Is whats in n_tty bulletproof if used properly.
-- 
best regards,
D.J. Barrow

^ permalink raw reply	[flat|nested] 2+ messages in thread

* re /drivers/char/n_tty.c drops characters
@ 2008-09-03  9:29 Denis Joseph Barrow
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Joseph Barrow @ 2008-09-03  9:29 UTC (permalink / raw)
  To: linux-kernel, Andrew Bird, Greg Kroah-Hartman, Jeff Garzik

Hi all,
It looks like the it was the intention that n_tty.c
would not drop characters in older kernels around 2.6.15 in the
n_tty layer if N_TTY_BUF_SIZE was 4096 bytes
as TTY_FLIPBUF_SIZE was only 512 bytes.

Now since 2.6.15 or so tty_buffer_alloc in tty_io.c is capible
of allocating a tty buffer of over 64k I believe this
means that the n_tty_receive_buf will overflow if tty_buffer_alloc 
throws a buffer of over 4k to n_tty_receive_buf.

Any comments?

-- 
best regards,
D.J. Barrow

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-03 10:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-03  8:32 re /drivers/char/n_tty.c drops characters Denis Joseph Barrow
  -- strict thread matches above, loose matches on Subject: below --
2008-09-03  9:29 Denis Joseph Barrow

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.