From: Jeff Garzik <jeff@garzik.org>
To: roel kluin <roel.kluin@gmail.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
david@gibson.dropbear.id.au
Subject: Re: [PATCH] ibm_newemac: MAL[12]_IER_EVENTS definition: 2x *_OTE -> *_DE
Date: Wed, 03 Sep 2008 10:08:45 -0400 [thread overview]
Message-ID: <48BE9A6D.1000109@garzik.org> (raw)
In-Reply-To: <48B9B218.6060506@gmail.com>
roel kluin wrote:
> MAL[12]_IER_EVENTS definitions have MAL_IER_OTE twice
> but lack MAL_IER_DE
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/net/ibm_newemac/mal.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ibm_newemac/mal.h b/drivers/net/ibm_newemac/mal.h
> index eaa7262..717dc38 100644
> --- a/drivers/net/ibm_newemac/mal.h
> +++ b/drivers/net/ibm_newemac/mal.h
> @@ -102,7 +102,7 @@
> /* MAL V1 IER bits */
> #define MAL1_IER_NWE 0x00000008
> #define MAL1_IER_SOC_EVENTS MAL1_IER_NWE
> -#define MAL1_IER_EVENTS (MAL1_IER_SOC_EVENTS | MAL_IER_OTE | \
> +#define MAL1_IER_EVENTS (MAL1_IER_SOC_EVENTS | MAL_IER_DE | \
> MAL_IER_OTE | MAL_IER_OE | MAL_IER_PE)
>
> /* MAL V2 IER bits */
> @@ -110,7 +110,7 @@
> #define MAL2_IER_PRE 0x00000040
> #define MAL2_IER_PWE 0x00000020
> #define MAL2_IER_SOC_EVENTS (MAL2_IER_PT | MAL2_IER_PRE | MAL2_IER_PWE)
> -#define MAL2_IER_EVENTS (MAL2_IER_SOC_EVENTS | MAL_IER_OTE | \
> +#define MAL2_IER_EVENTS (MAL2_IER_SOC_EVENTS | MAL_IER_DE | \
> MAL_IER_OTE | MAL_IER_OE | MAL_IER_PE)
applied
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: roel kluin <roel.kluin@gmail.com>
Cc: david@gibson.dropbear.id.au, benh@kernel.crashing.org,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ibm_newemac: MAL[12]_IER_EVENTS definition: 2x *_OTE -> *_DE
Date: Wed, 03 Sep 2008 10:08:45 -0400 [thread overview]
Message-ID: <48BE9A6D.1000109@garzik.org> (raw)
In-Reply-To: <48B9B218.6060506@gmail.com>
roel kluin wrote:
> MAL[12]_IER_EVENTS definitions have MAL_IER_OTE twice
> but lack MAL_IER_DE
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/net/ibm_newemac/mal.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ibm_newemac/mal.h b/drivers/net/ibm_newemac/mal.h
> index eaa7262..717dc38 100644
> --- a/drivers/net/ibm_newemac/mal.h
> +++ b/drivers/net/ibm_newemac/mal.h
> @@ -102,7 +102,7 @@
> /* MAL V1 IER bits */
> #define MAL1_IER_NWE 0x00000008
> #define MAL1_IER_SOC_EVENTS MAL1_IER_NWE
> -#define MAL1_IER_EVENTS (MAL1_IER_SOC_EVENTS | MAL_IER_OTE | \
> +#define MAL1_IER_EVENTS (MAL1_IER_SOC_EVENTS | MAL_IER_DE | \
> MAL_IER_OTE | MAL_IER_OE | MAL_IER_PE)
>
> /* MAL V2 IER bits */
> @@ -110,7 +110,7 @@
> #define MAL2_IER_PRE 0x00000040
> #define MAL2_IER_PWE 0x00000020
> #define MAL2_IER_SOC_EVENTS (MAL2_IER_PT | MAL2_IER_PRE | MAL2_IER_PWE)
> -#define MAL2_IER_EVENTS (MAL2_IER_SOC_EVENTS | MAL_IER_OTE | \
> +#define MAL2_IER_EVENTS (MAL2_IER_SOC_EVENTS | MAL_IER_DE | \
> MAL_IER_OTE | MAL_IER_OE | MAL_IER_PE)
applied
next prev parent reply other threads:[~2008-09-03 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-30 20:48 [PATCH] ibm_newemac: MAL[12]_IER_EVENTS definition: 2x *_OTE -> *_DE roel kluin
2008-09-01 0:30 ` Benjamin Herrenschmidt
2008-09-01 0:30 ` Benjamin Herrenschmidt
2008-09-03 14:08 ` Jeff Garzik [this message]
2008-09-03 14:08 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BE9A6D.1000109@garzik.org \
--to=jeff@garzik.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.