Re: [PATCH][origin/autotools] fix libtool_compat header error

Re: [PATCH][origin/autotools] fix libtool_compat header error

[Joshua Brindle]

Vikram Ambrose wrote:
> More stuff:
> 
> 1. Fixed error for libtool_compat.h in libsepol/libselinux
> 2. Renamed pam modules with pamd suffix to prevent overwriting
> corresponding binaries
> 3. Added --enable-test option to libsepol (no Makefile.am yet)
> 4. Added few more autogen.sh scripts
> 5. Added .gitignore file to prevent accidental checkin of autoconf temp
> files
> 
> Note: My SELinux work from now onwards will be unofficial, and any
> correspondence should be to my personal email address,
> noel.ambrose@gmail.com, or you can always catch me on IRC.
> 

(Back on list)

Looks much better, some things: policycoreutils apparently knows how to find libsepol.a by itself but checkpolicy doesn't?

Also, I'm still getting this from libselinux when I build out the optional support:
./configure --disable-rpm --disable-avc --disable-bool --disable-swig --disable-docs

gcc -shared  .libs/compute_member.o .libs/get_default_type.o .libs/lgetfilecon.o .libs/selinux_config.o .libs/compute_relabel.o .libs/getenforce.o .libs/load_policy.o .libs/compute_user.o .libs/getfilecon.o .libs/lsetfilecon.o .libs/setenforce.o .libs/context.o .libs/get_initial_context.o .libs/setfilecon.o .libs/disable.o .libs/getpeercon.o .libs/matchmediacon.o .libs/setrans_client.o .libs/callbacks.o .libs/enabled.o .libs/init.o .libs/matchpathcon.o .libs/seusers.o .libs/canonicalize_context.o .libs/fgetfilecon.o .libs/is_customizable_type.o .libs/policyvers.o .libs/freeconary.o .libs/label.o .libs/procattr.o .libs/check_context.o .libs/freecon.o .libs/label_file.o .libs/query_user_context.o .libs/compute_av.o .libs/fsetfilecon.o .libs/label_media.o .libs/compute_create.o .libs/get_context_list.o .libs/label_x.o .libs/selinux_check_securetty_context.o  -ldl  -Wl,--as-needed -Wl,-soname -Wl,libselinux.so.1 -o .libs/libselinux.so.1.0.0
/usr/bin/ld: .libs/load_policy.o: relocation R_X86_64_PC32 against undefined symbol `security_get_boolean_names_internal' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: ld returned 1 exit status

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH][origin/autotools] fix libtool_compat header error

[Vikram Noel Ambrose]

Joshua Brindle wrote:
> Vikram Ambrose wrote:
>   
>> More stuff:
>>
>> 1. Fixed error for libtool_compat.h in libsepol/libselinux
>> 2. Renamed pam modules with pamd suffix to prevent overwriting
>> corresponding binaries
>> 3. Added --enable-test option to libsepol (no Makefile.am yet)
>> 4. Added few more autogen.sh scripts
>> 5. Added .gitignore file to prevent accidental checkin of autoconf temp
>> files
>>
>> Note: My SELinux work from now onwards will be unofficial, and any
>> correspondence should be to my personal email address,
>> noel.ambrose@gmail.com, or you can always catch me on IRC.
>>
>>     
>
> (Back on list)
>
> Looks much better, some things: policycoreutils apparently knows how to find libsepol.a by itself but checkpolicy doesn't?
>
>   

The tests that policycoreutils and checkpolicy does for libsepol.a is 
very similar, except checkpolicy does a little more to make sure the 
library is finds is actually compatible.

eg. line 48 of checkpolicy/configure.ac
if ! nm "$with_static_libsepol/libsepol.a" 2>&1 | grep -q 
sepol_polcap_getnum ; then
   AC_MSG_ERROR([libsepol.a not compatible])
fi

That function "sepol_polcap_getnum" was added relatively recently, and I 
noticed that when doing development, by mistake I would build against a 
older system wide version of the library that didnt have this function, 
and the build would error out, so i added this test, to make sure that 
the libsepol.a found, was indeed compatible, if you are getting strange 
results, pastebin your config.log and i'll have a look at it.



> Also, I'm still getting this from libselinux when I build out the optional support:
> ./configure --disable-rpm --disable-avc --disable-bool --disable-swig --disable-docs
>
> gcc -shared  .libs/compute_member.o .libs/get_default_type.o .libs/lgetfilecon.o .libs/selinux_config.o .libs/compute_relabel.o .libs/getenforce.o .libs/load_policy.o .libs/compute_user.o .libs/getfilecon.o .libs/lsetfilecon.o .libs/setenforce.o .libs/context.o .libs/get_initial_context.o .libs/setfilecon.o .libs/disable.o .libs/getpeercon.o .libs/matchmediacon.o .libs/setrans_client.o .libs/callbacks.o .libs/enabled.o .libs/init.o .libs/matchpathcon.o .libs/seusers.o .libs/canonicalize_context.o .libs/fgetfilecon.o .libs/is_customizable_type.o .libs/policyvers.o .libs/freeconary.o .libs/label.o .libs/procattr.o .libs/check_context.o .libs/freecon.o .libs/label_file.o .libs/query_user_context.o .libs/compute_av.o .libs/fsetfilecon.o .libs/label_media.o .libs/compute_create.o .libs/get_context_list.o .libs/label_x.o .libs/selinux_check_securetty_context.o  -ldl  -Wl,--as-needed -Wl,-soname -Wl,libselinux.so.1 -o .libs/libselinux.so.1.0.0
> /usr/bin/ld: .libs/load_policy.o: relocation R_X86_64_PC32 against undefined symbol `security_get_boolean_names_internal' can not be used when making a shared object; recompile with -fPIC
> /usr/bin/ld: final link failed: Bad value
> collect2: ld returned 1 exit status
>
>   

I was missing a macro, fixed.

Will email patch later on, after some more testing.


Oh before i forget. It would be nice to add NEWS, README and AUTHORS 
files to each package folder, no mandatory, but would make life easier, 
as these files need to be generated before autoconf can be run, and it 
would be better to have meaningful content for these files then stubbing 
it out on the fly from the autogen.sh script. If there is no objection I 
will create a separate commit for these files.

Vikram




--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH][origin/autotools] fix libtool_compat header error

[Joshua Brindle]

Vikram Noel Ambrose wrote:
> Joshua Brindle wrote:
>> Vikram Ambrose wrote:
<snip> 
> Oh before i forget. It would be nice to add NEWS, README and AUTHORS
> files to each package folder, no mandatory, but would make life easier,
> as these files need to be generated before autoconf can be run, and it
> would be better to have meaningful content for these files then stubbing
> it out on the fly from the autogen.sh script. If there is no objection I
> will create a separate commit for these files.
> 

I removed them from the previous patch because they were incomplete and may have been seen as offensive to some (eg., the AUTHORS file only had you and I listed). There are quite a few contributors to this code and I'm not even sure if I could collect them all. Steve might be able to though, since he has some sort of bionic brain.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH][origin/autotools] fix libtool_compat header error

[Stephen Smalley]

On Thu, 2008-09-04 at 10:09 -0400, Joshua Brindle wrote:
> Vikram Noel Ambrose wrote:
> > Joshua Brindle wrote:
> >> Vikram Ambrose wrote:
> <snip> 
> > Oh before i forget. It would be nice to add NEWS, README and AUTHORS
> > files to each package folder, no mandatory, but would make life easier,
> > as these files need to be generated before autoconf can be run, and it
> > would be better to have meaningful content for these files then stubbing
> > it out on the fly from the autogen.sh script. If there is no objection I
> > will create a separate commit for these files.
> > 
> 
> I removed them from the previous patch because they were incomplete
> and may have been seen as offensive to some (eg., the AUTHORS file
> only had you and I listed). There are quite a few contributors to this
> code and I'm not even sure if I could collect them all. Steve might be
> able to though, since he has some sort of bionic brain.

We could likely generate an approximate list from a combination of the
Author comments in the source files and the ChangeLog files.

Cast of thousands, including but not limited to:
...

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.