* + fix-fastboot-make-the-raid-autodetect-code-wait-for-all-devices-to-init.patch added to -mm tree
@ 2008-09-04 5:39 akpm
2008-09-04 16:45 ` Randy.Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: akpm @ 2008-09-04 5:39 UTC (permalink / raw)
To: mm-commits; +Cc: akpm, arjan, arjan, mingo
The patch titled
fix "fastboot: make the raid autodetect code wait for all devices to init"
has been added to the -mm tree. Its filename is
fix-fastboot-make-the-raid-autodetect-code-wait-for-all-devices-to-init.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: fix "fastboot: make the raid autodetect code wait for all devices to init"
From: Andrew Morton <akpm@linux-foundation.org>
: commit b52c36a95ed8026b6925fe8595ebcab6921ae62d
: Author: Arjan van de Ven <arjan@linux.intel.com>
: Date: Sun Jul 20 13:07:09 2008 -0700
:
: fastboot: make the raid autodetect code wait for all devices to init
init/do_mounts_md.c: In function `md_run_setup':
init/do_mounts_md.c:282: warning: ISO C90 forbids mixed declarations and code
How did this happen?
Cc: Arjan van de Ven <arjan@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
init/do_mounts_md.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN init/do_mounts_md.c~fix-fastboot-make-the-raid-autodetect-code-wait-for-all-devices-to-init init/do_mounts_md.c
--- a/init/do_mounts_md.c~fix-fastboot-make-the-raid-autodetect-code-wait-for-all-devices-to-init
+++ a/init/do_mounts_md.c
@@ -271,6 +271,8 @@ void __init md_run_setup(void)
if (raid_noautodetect)
printk(KERN_INFO "md: Skipping autodetection of RAID arrays. (raid=noautodetect)\n");
else {
+ int fd;
+
/*
* Since we don't want to detect and use half a raid array, we need to
* wait for the known devices to complete their probing
@@ -279,7 +281,7 @@ void __init md_run_setup(void)
printk(KERN_INFO "md: If you don't use raid, use raid=noautodetect\n");
while (driver_probe_done() < 0)
msleep(100);
- int fd = sys_open("/dev/md0", 0, 0);
+ fd = sys_open("/dev/md0", 0, 0);
if (fd >= 0) {
sys_ioctl(fd, RAID_AUTORUN, raid_autopart);
sys_close(fd);
_
Patches currently in -mm which might be from akpm@linux-foundation.org are
origin.patch
linux-next.patch
next-remove-localversion.patch
linux-next-avoid-genhdc-oops.patch
drivers-mfd-ucb1400_corec-needs-gpio.patch
drivers-mfd-ucb1400_corec-further-unbork.patch
kbuild-ftrace-dont-assume-that-scripts-recordmcountpl-is-executable.patch
acpi-ec-dont-degrade-to-poll-mode-at-storm-automatically-cleanup.patch
toshiba_acpi-add-support-for-bluetooth-toggling-through-rfkill-v7-fix.patch
toshiba_acpi-add-support-for-bluetooth-toggling-through-rfkill-v7-fix-fix.patch
zero-based-percpu-use-vmlinux_symbol-in-include-asm-generic-vmlinuxldsh.patch
x86-make-poll_idle-behave-more-like-the-other-idle-methods-checkpatch-fixes.patch
drivers-rtc-rtc-bq4802c-dont-use-bin_2_bcd-and-bcd_2_bin.patch
fs-sysfs-dirc-remove-unused-__sysfs_get_dentry.patch
fs-dlm-configc-choose-better-identifiers.patch
tick-schedc-suppress-needless-timer-reprogramming.patch
drivers-input-touchscreen-ucb1400_tsc-needs-gpio.patch
git-jg-misc.patch
led-driver-for-leds-on-pcengines-alix2-and-alix3-boards.patch
libata-blackfin-pata-driver-add-proper-pm-operation-into-atapi-driver-fix.patch
sundance-set-carrier-status-on-link-change-events.patch
cassini-use-request_firmware.patch
e1000e-avoid-duplicated-output-of-device-name-in-kernel-warning-checkpatch-fixes.patch
e1000e-avoid-duplicated-output-of-device-name-in-kernel-warning-fix.patch
backlight-driver-for-tabletkiosk-sahara-touchit-213-tablet-pc.patch
backlight-driver-for-tabletkiosk-sahara-touchit-213-tablet-pc-update-2-checkpatch-fixes.patch
pci-tidy-pme-support-messages-checkpatch-fixes.patch
sched-clarify-ifdef-tangle.patch
fix-fastboot-make-the-raid-autodetect-code-wait-for-all-devices-to-init.patch
scsi-gdthc-use-unaligned-access-helpers.patch
drivers-scsi-device_handler-scsi_dh_emcc-suppress-warning.patch
drivers-rtc-kconfig-dont-build-rtc-cmoso-on-sparc32.patch
git-xtensa.patch
modules-remove-stop_machine-during-module-load-checkpatch-fixes.patch
scsi-dpt_i2o-is-bust-on-ia64.patch
drivers-media-video-cafe_ccicc-needs-mmh.patch
e1000e-prevent-corruption-of-eeprom-nvm.patch
drivers-net-mlx4-allocc-needs-mmh.patch
mm-page_allocc-free_area_init_nodes-fix-inappropriate-use-of-enum.patch
vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch
vm-dont-run-touch_buffer-during-buffercache-lookups.patch
vmscan-move-isolate_lru_page-to-vmscanc.patch
define-page_file_cache-function.patch
vmscan-split-lru-lists-into-anon-file-sets.patch
unevictable-lru-infrastructure.patch
unevictable-lru-page-statistics.patch
mlock-mlocked-pages-are-unevictable.patch
mlock-mlocked-pages-are-unevictable-fix.patch
mmap-handle-mlocked-pages-during-map-remap-unmap.patch
mmap-handle-mlocked-pages-during-map-remap-unmap-mlock-resubmit-locked_vm-adjustment-as-separate-patch-fix.patch
vmscan-unevictable-lru-scan-sysctl.patch
mlock-make-mlock-error-return-posixly-correct-fix.patch
mm-rewrite-vmap-layer-fix.patch
mm-rewrite-vmap-layer-fix-fix.patch
mm-rewrite-vmap-layer-fix-fix-fix.patch
h8300-generic_bug-support-checkpatch-fixes.patch
pm-rework-disabling-of-user-mode-helpers-during-suspend-hibernation-cleanup.patch
container-freezer-add-tif_freeze-flag-to-all-architectures-fix.patch
container-freezer-implement-freezer-cgroup-subsystem-checkpatch-fixes.patch
container-freezer-implement-freezer-cgroup-subsystem-uninline-thaw_process-fix.patch
separate-atomic_t-declaration-from-asm-atomich-into-asm-atomic_defh-fix.patch
separate-atomic_t-declaration-from-asm-atomich-into-asm-atomic_defh-fix-fix.patch
fix-a-race-condtion-of-oops_in_progress-fix.patch
vsprintf-use-new-vsprintf-symbolic-function-pointer-format-cleanup.patch
autofs4-track-uid-and-gid-of-last-mount-requester-fix.patch
autofs4-add-miscellaneous-device-for-ioctls-fix.patch
autofs4-add-miscellaneous-device-for-ioctls-fix-2.patch
autofs4-add-miscellaneous-device-for-ioctls-fix-fix-3.patch
rtc-add-device-driver-for-dallas-ds3234-spi-rtc-chip-fix.patch
fb-push-down-the-bkl-in-the-ioctl-handler-checkpatch-fixes.patch
viafb-viafbmodes-viafbtxt-fix-fix.patch
viafb-accelc-accelh-checkpatch-fixes.patch
viafb-dvic-dvih-globalc-and-globalh-checkpatch-fixes.patch
viafb-hwc-hwh-checkpatch-fixes.patch
viafb-viafbdevc-viafbdevh-checkpatch-fixes.patch
fbdev-kconfig-update-fix.patch
eink_apollofb-new-driver-for-apollo-eink-controller.patch
cgroups-fix-probable-race-with-put_css_set-and-find_css_set-fix.patch
memrlimit-add-memrlimit-controller-accounting-and-control-mm_owner-fix-checkpatch-fixes.patch
message-queues-increase-range-limits-checkpatch-fixes.patch
applicomc-fix-apparently-broken-code-in-do_ac_read.patch
drivers-char-tpm-tpmc-fix-error-patch-memory-leak.patch
gru-driver-minor-updates-fix.patch
gcov-architecture-specific-compile-flag-adjustments-powerpc-moved-stuff.patch
nilfs2-continuous-snapshotting-file-system-fix.patch
nilfs2-continuous-snapshotting-file-system-fix-fix-2.patch
reiser4.patch
reiser4-tree_lock-fixes.patch
reiser4-tree_lock-fixes-fix.patch
reiser4-semaphore-fix.patch
slb-drop-kmem-cache-argument-from-constructor-reiser4.patch
reiser4-suid.patch
reiser4-track-upstream-changes.patch
page-owner-tracking-leak-detector.patch
nr_blockdev_pages-in_interrupt-warning.patch
slab-leaks3-default-y.patch
put_bh-debug.patch
shrink_slab-handle-bad-shrinkers.patch
getblk-handle-2tb-devices.patch
getblk-handle-2tb-devices-fix.patch
undeprecate-pci_find_device.patch
notify_change-callers-must-hold-i_mutex.patch
profile-likely-unlikely-macros.patch
drivers-net-bonding-bond_sysfsc-suppress-uninitialized-var-warning.patch
w1-build-fix.patch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: + fix-fastboot-make-the-raid-autodetect-code-wait-for-all-devices-to-init.patch added to -mm tree
2008-09-04 5:39 + fix-fastboot-make-the-raid-autodetect-code-wait-for-all-devices-to-init.patch added to -mm tree akpm
@ 2008-09-04 16:45 ` Randy.Dunlap
2008-09-04 17:36 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Randy.Dunlap @ 2008-09-04 16:45 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, arjan, arjan, mingo
On Wed, 3 Sep 2008, akpm@linux-foundation.org wrote:
> Subject: fix "fastboot: make the raid autodetect code wait for all devices to init"
> From: Andrew Morton <akpm@linux-foundation.org>
>
> : commit b52c36a95ed8026b6925fe8595ebcab6921ae62d
> : Author: Arjan van de Ven <arjan@linux.intel.com>
> : Date: Sun Jul 20 13:07:09 2008 -0700
> :
> : fastboot: make the raid autodetect code wait for all devices to init
>
> init/do_mounts_md.c: In function `md_run_setup':
> init/do_mounts_md.c:282: warning: ISO C90 forbids mixed declarations and code
>
> How did this happen?
There are so many warnings that they get lost in the noise
unless someone is actively looking for them.
If I modify a source file, I try to check its build status afterwards
and not just that the kernel build succeeded.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: + fix-fastboot-make-the-raid-autodetect-code-wait-for-all-devices-to-init.patch added to -mm tree
2008-09-04 16:45 ` Randy.Dunlap
@ 2008-09-04 17:36 ` Andrew Morton
2008-09-04 17:38 ` Arjan van de Ven
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-09-04 17:36 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: linux-kernel, arjan, arjan, mingo
On Thu, 4 Sep 2008 09:45:10 -0700 (PDT) "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> On Wed, 3 Sep 2008, akpm@linux-foundation.org wrote:
>
> > Subject: fix "fastboot: make the raid autodetect code wait for all devices to init"
> > From: Andrew Morton <akpm@linux-foundation.org>
> >
> > : commit b52c36a95ed8026b6925fe8595ebcab6921ae62d
> > : Author: Arjan van de Ven <arjan@linux.intel.com>
> > : Date: Sun Jul 20 13:07:09 2008 -0700
> > :
> > : fastboot: make the raid autodetect code wait for all devices to init
> >
> > init/do_mounts_md.c: In function `md_run_setup':
> > init/do_mounts_md.c:282: warning: ISO C90 forbids mixed declarations and code
> >
> > How did this happen?
>
> There are so many warnings that they get lost in the noise
> unless someone is actively looking for them.
Well if that's the explanation then OK (sort-of). I'm more concerned
that the warning does not appear *at all* for some people's
compiler/Kconfig combinations.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: + fix-fastboot-make-the-raid-autodetect-code-wait-for-all-devices-to-init.patch added to -mm tree
2008-09-04 17:36 ` Andrew Morton
@ 2008-09-04 17:38 ` Arjan van de Ven
0 siblings, 0 replies; 4+ messages in thread
From: Arjan van de Ven @ 2008-09-04 17:38 UTC (permalink / raw)
To: Andrew Morton; +Cc: Randy.Dunlap, linux-kernel, arjan, mingo
Andrew Morton wrote:
> On Thu, 4 Sep 2008 09:45:10 -0700 (PDT) "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
>> On Wed, 3 Sep 2008, akpm@linux-foundation.org wrote:
>>
>>> Subject: fix "fastboot: make the raid autodetect code wait for all devices to init"
>>> From: Andrew Morton <akpm@linux-foundation.org>
>>>
>>> : commit b52c36a95ed8026b6925fe8595ebcab6921ae62d
>>> : Author: Arjan van de Ven <arjan@linux.intel.com>
>>> : Date: Sun Jul 20 13:07:09 2008 -0700
>>> :
>>> : fastboot: make the raid autodetect code wait for all devices to init
>>>
>>> init/do_mounts_md.c: In function `md_run_setup':
>>> init/do_mounts_md.c:282: warning: ISO C90 forbids mixed declarations and code
>>>
>>> How did this happen?
>> There are so many warnings that they get lost in the noise
>> unless someone is actively looking for them.
>
> Well if that's the explanation then OK (sort-of). I'm more concerned
> that the warning does not appear *at all* for some people's
> compiler/Kconfig combinations.
it's weird; I could have sworn I had this fixed before sending the patch
out in the first place (I did notice the warning and remember fixing it)
probably a tool/flow issue on my side (forgetting quilt add/git add or something)
apologies for that
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-09-04 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-04 5:39 + fix-fastboot-make-the-raid-autodetect-code-wait-for-all-devices-to-init.patch added to -mm tree akpm
2008-09-04 16:45 ` Randy.Dunlap
2008-09-04 17:36 ` Andrew Morton
2008-09-04 17:38 ` Arjan van de Ven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.