All of lore.kernel.org
 help / color / mirror / Atom feed
* DVB Update [PATCH 22/31] multiproto tree
@ 2008-09-04 18:41 Manu Abraham
  0 siblings, 0 replies; only message in thread
From: Manu Abraham @ 2008-09-04 18:41 UTC (permalink / raw)
  To: linux-kernel, v4l-dvb-maintainer, akpm; +Cc: marco

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

>From a4d4b171211d0c71eda0f807506e905df2b9e4ef Mon Sep 17 00:00:00 2001
From: Manu Abraham <manu@linuxtv.org>
Date: Thu, 4 Sep 2008 14:24:28 +0200
Subject: [PATCH] DVB fix broken backward compatibility for DVBFE_GET_PARAMS

DVBFE_GET_PARAMS 's backward compatibily was broken due to a
wrong copy. Fix it.

Thanks to Marco Schluessler <marco@lordzodiac.de> for pointing
out the bug.

From: Manu Abraham <abraham.manu@gmail.com>
Signed-off-by: Manu Abraham <manu@linuxtv.org>

 dvb_frontend.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[-- Attachment #2: 22.patch --]
[-- Type: text/x-patch, Size: 1301 bytes --]

>From a4d4b171211d0c71eda0f807506e905df2b9e4ef Mon Sep 17 00:00:00 2001
From: Manu Abraham <manu@linuxtv.org>
Date: Thu, 4 Sep 2008 14:24:28 +0200
Subject: [PATCH] DVB fix broken backward compatibility for DVBFE_GET_PARAMS

DVBFE_GET_PARAMS 's backward compatibily was broken due to a
wrong copy. Fix it.

Thanks to Marco Schluessler <marco@lordzodiac.de> for pointing
out the bug.

From: Manu Abraham <abraham.manu@gmail.com>
Signed-off-by: Manu Abraham <manu@linuxtv.org>

diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index 2b28bd1..24ae622 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -1816,7 +1816,7 @@ static int dvb_frontend_ioctl(struct inode *inode, struct file *file,
 			memcpy(parg, &fepriv->fe_params, sizeof (struct dvbfe_params));
 			err = fe->ops.get_params(fe, (struct dvbfe_params *) parg);
 		} else if (fe->ops.get_frontend) {
-			err = fe->ops.get_frontend(fe, (struct dvb_frontend_parameters*) parg);
+			err = fe->ops.get_frontend(fe, &fepriv->parameters);
 			if (!err) {
 				if (olddrv_to_newapi(fe, &fepriv->fe_params, &fepriv->parameters, fe->ops.info.type) == -EINVAL)
 					printk("%s: ERROR !!! Converting Old parameters --> New parameters\n", __func__);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-09-04 18:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-04 18:41 DVB Update [PATCH 22/31] multiproto tree Manu Abraham

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.