From: Ilya Yanok <yanok@emcraft.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
wd@denx.de, yur@emcraft.com,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] ASYNC_TX: fix the bug in async_tx_run_dependencies
Date: Fri, 05 Sep 2008 13:15:42 +0400 [thread overview]
Message-ID: <48C0F8BE.7060108@emcraft.com> (raw)
In-Reply-To: <20080904141945.f5c4c3eb.akpm@linux-foundation.org>
Andrew Morton wrote:
>> From: Yuri Tikhonov <yur@emcraft.com>
>>
>> Should clear the next pointer of the TX if we are sure that the
>> next TX (say NXT) will be submitted to the channel too. Overwise,
>> we break the chain of descriptors, because we lose the information
>> about the next descriptor to run. So next time, when invoke
>> async_tx_run_dependencies() with TX, it's TX->next will be NULL, and
>> NXT will be never submitted.
>>
>> Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
>>
Signed-off-by: Ilya Yanok <yanok@emcraft.com>
> This patch should include your signed-off-by: as well. Because you
> were on the delivery path, as described in
> Documentation/SubmittingPatches, section 12.
>
Excuse me for being inattentive.
Regards, Ilya.
next prev parent reply other threads:[~2008-09-05 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 21:43 [PATCH] ASYNC_TX: fix the bug in async_tx_run_dependencies Ilya Yanok
2008-09-04 21:19 ` Andrew Morton
2008-09-04 23:24 ` Dan Williams
2008-09-05 0:03 ` Dan Williams
2008-09-05 10:17 ` Ilya Yanok
2008-09-05 9:15 ` Ilya Yanok [this message]
2008-09-05 13:06 ` Wolfgang Denk
2008-09-05 13:16 ` Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C0F8BE.7060108@emcraft.com \
--to=yanok@emcraft.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=wd@denx.de \
--cc=yur@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.