All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Yanok <yanok@emcraft.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
	wd@denx.de, yur@emcraft.com
Subject: Re: [PATCH] ASYNC_TX: fix the bug in async_tx_run_dependencies
Date: Fri, 05 Sep 2008 14:17:22 +0400	[thread overview]
Message-ID: <48C10732.1050009@emcraft.com> (raw)
In-Reply-To: <e9c3a7c20809041703h5bf6a007g6dcbe8fb2a5deffd@mail.gmail.com>

Hello,

Dan Williams wrote:
> Please also take a look at this cleanup patch that I will queue for
> .28.  I think it makes things easier to read let me know if you
> disagree.
>   

Look good for me. Hmm, actually I don't think that current version is so
hard to read...

Just one comment:

> -	if (!next)
> +	if (dep)
> +		chan = dep->chan;
> +	else
>  		return;
>   

I don't like 'return' inside 'else'.

Regards, Ilya.


  reply	other threads:[~2008-09-05 10:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03 21:43 [PATCH] ASYNC_TX: fix the bug in async_tx_run_dependencies Ilya Yanok
2008-09-04 21:19 ` Andrew Morton
2008-09-04 23:24   ` Dan Williams
2008-09-05  0:03     ` Dan Williams
2008-09-05 10:17       ` Ilya Yanok [this message]
2008-09-05  9:15   ` Ilya Yanok
2008-09-05 13:06 ` Wolfgang Denk
2008-09-05 13:16   ` Ilya Yanok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C10732.1050009@emcraft.com \
    --to=yanok@emcraft.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=wd@denx.de \
    --cc=yur@emcraft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.