From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: Zhao Yakui <yakui.zhao@intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>, Andi Kleen <andi@firstfloor.org>,
linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>
Subject: Re: patch for bugs 9998 and 10724
Date: Fri, 05 Sep 2008 16:58:50 +0400 [thread overview]
Message-ID: <48C12D0A.6020704@suse.de> (raw)
In-Reply-To: <1220586550.4007.185.camel@yakui_zhao.sh.intel.com>
Zhao Yakui wrote:
> If the system is already switched to GPE mode, how to continue EC
> transaction if there is no GPE interrupt confirmation in some EC
> transaction? For example: on the laptops of bug 11428 & 8459. In fact
> sometimes there is no EC GPE interrupt confirmation only for the last
> step of EC transaction(OBF bit already indicates that data is ready but
> there is no EC interrupt).
You can't read, do you?
If the interrupt does not arrive for OBF in the middle of transaction,
transaction will be completed after the GPE_MODE is cleared in acpi_wait()
in a poll loop below, there is even a comment for that.
/* start transaction */
acpi_ec_write_cmd(ec, command);
>>>>> /* if we selected poll mode or failed in GPE-mode do a poll loop */
if (force_poll ||
!test_bit(EC_FLAGS_GPE_MODE, &ec->flags) ||
acpi_ec_wait(ec)) {
delay = jiffies + msecs_to_jiffies(ACPI_EC_DELAY);
while (time_before(jiffies, delay)) {
gpe_transaction(ec, acpi_ec_read_status(ec));
msleep(1);
if (ec_transaction_done(ec))
goto end;
}
}
next prev parent reply other threads:[~2008-09-05 12:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 5:57 [PATCH] ACPI : Avoid bogus timeout about SMbus check Zhao Yakui
2008-09-04 12:18 ` Andi Kleen
2008-09-04 12:33 ` patch for bugs 9998 and 10724 Alexey Starikovskiy
2008-09-04 12:35 ` Alexey Starikovskiy
2008-09-04 13:18 ` Andi Kleen
2008-09-05 2:26 ` Zhang Rui
2008-09-05 3:49 ` Zhao Yakui
2008-09-05 12:58 ` Alexey Starikovskiy [this message]
2008-09-08 1:18 ` Zhao Yakui
2008-09-05 12:45 ` Alexey Starikovskiy
2008-09-08 2:56 ` Zhang Rui
2008-09-08 8:25 ` Alexey Starikovskiy
2008-09-09 9:13 ` Zhao Yakui
2008-09-09 9:12 ` Alexey Starikovskiy
2008-09-09 9:28 ` Alexey Starikovskiy
2008-09-09 9:43 ` Zhao Yakui
2008-09-09 9:36 ` Alexey Starikovskiy
2008-09-10 1:15 ` Zhao Yakui
2008-09-10 2:23 ` Alexey Starikovskiy
2008-09-11 19:49 ` [PATCH] ACPI : Avoid bogus timeout about SMbus check Oldrich Jedlicka
2008-09-11 21:13 ` Alexey Starikovskiy
2008-09-14 20:06 ` Oldrich Jedlicka
2008-09-12 1:38 ` Zhao Yakui
2008-09-14 20:17 ` Oldrich Jedlicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C12D0A.6020704@suse.de \
--to=astarikovskiy@suse.de \
--cc=andi@firstfloor.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.