Re: patch for bugs 9998 and 10724

[Alexey Starikovskiy <astarikovskiy@suse.de>]

One more thought. One of your patches increase the time of
QUERY_PENDING bit significantly (by including whole notify handling into it),
so you need to worry more about it, and not my patch :)

Your patch actually fails to address it's purpose, as the main
consumer of queries on these broken machines is SBS HC, which does it's
own deferred execution right now. This fact saves you at the moment, as
QUERY_PENDING needs to be clear (and be able to send more queries) 
for execution of SBS HC callback to complete.

Regards,
Alex.

Alexey Starikovskiy wrote:
> Zhao Yakui wrote:
>> Hi, Alexey
>>     You attached the updated patch on the bug 10724/9998.
>>     Can the following situation be handled by your patch?(For example:
>> bug 10724)
>>        EC GPE Interrupt storm is detected and EC GPE will be disabled
>> when doing EC transaction.
>>        If EC notification event happens while doing EC transaction(EC
>> GPE is disabled), the SCI_EVT bit of EC status register is cleared
>> automatically before we can handle it.
> SCI_EVT is cleared only as a response to query command sent to EC, there 
> is no timeout on it.
> Transaction will take at most 2 ms (1 write/1 read or 2 writes in poll 
> mode), and at the end of the transaction there is a check of the SCI bit.
> With the un-patched EC SCI bit needs to stay for period while the 
> QUERY_PENDING bit is set,
> which could be quite more than 2 ms, and it seems to comply with that 
> even on most broken
> hardware.
>>        Can the EC notification event be handled by OS?
> What do you mean?
>>
>>  Thanks
>>      Yakui.
> Please strip unneeded tails from your mails.
>