From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] GSoC #06 VBE optimization for BGR/BGRA color modes
Date: Sun, 07 Sep 2008 18:59:03 +0300 [thread overview]
Message-ID: <48C3FA47.7070807@nic.fi> (raw)
In-Reply-To: <20080830235655.56f41dc5@gamma.lan>
Colin D Bennett wrote:
> This patch adds optimized routines for video modes using BGR/BGRA color
> format. Most PC video cards use BGR (24-bit) or BGRA (32-bit) color
> modes, so this is an extremely important change and provides a massive
> performance benefit.
>
> I also renamed the R8G8B8A8 and R8B8B8 modes to RGBA8888 and RGB888,
> etc., since it began to be highly unreadable when B8G8R8A8 was added
> into the mix. It seems that having the color components (letters)
> grouped together in the name makes it much easier for me to determine
> the mode name at a glance.
Thanks for the patch. I have committed similar version to SVN.
I made some changes there so apologies if it broke something in between.
I was only able to test it on qemu and it was ok there, but that is far
from complete test. So please test it on real hardware with different
cards and if problems are found report them back.
Thanks,
Vesa Jääskeläinen
prev parent reply other threads:[~2008-09-07 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-31 6:56 [PATCH] GSoC #06 VBE optimization for BGR/BGRA color modes Colin D Bennett
2008-09-07 15:59 ` Vesa Jääskeläinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C3FA47.7070807@nic.fi \
--to=chaac@nic.fi \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.