Re: [PATCH] Ath9k: Add RF kill support.

[vasanthakumar thiagarajan <vasanth.thiagarajan@atheros.com>]

Henrique de Moraes Holschuh wrote:
> On Mon, 08 Sep 2008, Vasanthakumar Thiagarajan wrote:
>   
>> On Sat, Sep 06, 2008 at 10:45:47PM +0530, Marcel Holtmann wrote:
>>     
>>>> CONFIG_ATH9K_RFKILL needs to be set
>>>> to enable this support.
>>>>         
>>> why do we have to introduce yet another config option for this? What is
>>> the advantage of disabling RFKILL support? I really don't see it and all
>>> these extra config options are rather confusing than useful.
>>>       
>> Normally home users may not hit a situation where they have to
>> disable the radio, so they can compile out the rf kill support
>> and essentially disable the periodic run of the work queue
>> (rfkill_poll ,runs for every 2 secs).If this does not make
>> any sense, I will remove this config option.
>>     
>
> What doesn't make sense at all is to have it manually selectable.  Just
> define it to the same value of CONFIG_RFKILL, or use CONFIG_RFKILL directly
> outright.
>   
ok, thanks.

Vasanth