From: vasanthakumar thiagarajan <vasanth.thiagarajan@atheros.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Jouni Malinen <Jouni.Malinen@Atheros.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH] ath9k: Add RF kill support
Date: Tue, 9 Sep 2008 21:45:20 +0530 [thread overview]
Message-ID: <48C6A118.7030205@atheros.com> (raw)
In-Reply-To: <20080909161533.GA31478@khazad-dum.debian.net>
Henrique de Moraes Holschuh wrote:
> On Tue, 09 Sep 2008, vasanthakumar thiagarajan wrote:
>
>> I just rearranged (purely change in the location of few static functions
>> in the file) the code to avoid
>> the prototype declaration of the functions which are called (before
>> their definition) in case of any
>> failure during rfkill_register().
>>
>
> That's much better done in two patches.
>
> The first patch should just move code around without changing *anything*.
> You can check the resulting binary to be sure you didn't change any code by
> mistake.
>
> The second patch does the real code changes.
>
> --
> "One disk to rule them all, One disk to find them. One disk to bring
> them all and in the darkness grind them. In the Land of Redmond
> where the shadows lie." -- The Silicon Valley Tarot
> Henrique Holschuh
>
Yeah, I got it. Thanks.
Vasanth
next prev parent reply other threads:[~2008-09-09 16:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 15:34 [PATCH] ath9k: Add RF kill support Vasanthakumar Thiagarajan
2008-09-09 15:42 ` Johannes Berg
2008-09-09 16:22 ` vasanthakumar thiagarajan
2008-09-09 15:46 ` Johannes Berg
2008-09-09 16:02 ` vasanthakumar thiagarajan
2008-09-09 16:15 ` Henrique de Moraes Holschuh
2008-09-09 16:15 ` vasanthakumar thiagarajan [this message]
2008-09-09 16:19 ` Henrique de Moraes Holschuh
-- strict thread matches above, loose matches on Subject: below --
2008-09-09 5:33 [PATCH] Ath9k: " Mats Johannesson
2008-09-06 12:38 Vasanthakumar Thiagarajan
2008-09-06 17:15 ` Marcel Holtmann
2008-09-06 17:19 ` Johannes Berg
2008-09-06 17:23 ` Johannes Berg
2008-09-07 1:00 ` Marcel Holtmann
2008-09-07 7:17 ` Johannes Berg
2008-09-07 11:56 ` Henrique de Moraes Holschuh
2008-09-07 12:40 ` Johannes Berg
2008-09-07 0:57 ` Marcel Holtmann
2008-09-08 4:59 ` Vasanthakumar Thiagarajan
2008-09-08 5:22 ` Marcel Holtmann
2008-09-08 5:38 ` Vasanthakumar Thiagarajan
2008-09-08 15:10 ` Henrique de Moraes Holschuh
2008-09-09 7:53 ` vasanthakumar thiagarajan
2008-09-07 12:09 ` Henrique de Moraes Holschuh
2008-09-08 5:20 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C6A118.7030205@atheros.com \
--to=vasanth.thiagarajan@atheros.com \
--cc=Jouni.Malinen@Atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=hmh@hmh.eng.br \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.