All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [patch 2.6.27-rc6 4/6 ] hwmon/pc87360 separate sysfs
@ 2008-09-10  9:37 Jim Cromie
  2008-09-11  0:03 ` [lm-sensors] [patch 2.6.27-rc6 4/6 ] hwmon/pc87360 separate Andrew Morton
  2008-09-11  3:52 ` Jim Cromie
  0 siblings, 2 replies; 3+ messages in thread
From: Jim Cromie @ 2008-09-10  9:37 UTC (permalink / raw)
  To: lm-sensors

[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]

inlined and attached

 From e1750cd32128cc7a17dfc15f3920f3d184b8bbff Mon Sep 17 00:00:00 2001
From: Jim Cromie <jim.cromie@gmail.com>
Date: Sat, 28 Jun 2008 13:40:50 -0600
Subject: [PATCH] hwmon/pc87360 separate alarm files - define LDNI_MAX const

Driver handles 3 logical devices in fixed length array.
Give this a define-d constant.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 drivers/hwmon/pc87360.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
index 6ffea41..ebb235b 100644
--- a/drivers/hwmon/pc87360.c
+++ b/drivers/hwmon/pc87360.c
@@ -75,7 +75,8 @@ MODULE_PARM_DESC(force_id, "Override the detected 
device ID");
 #define FSCM    0x09    /* Logical device: fans */
 #define VLM    0x0d    /* Logical device: voltages */
 #define TMS    0x0e    /* Logical device: temperatures */
-static const u8 logdev[3] = { FSCM, VLM, TMS };
+#define LDNI_MAX 3
+static const u8 logdev[LDNI_MAX] = { FSCM, VLM, TMS };
 
 #define LD_FAN        0
 #define LD_IN        1
@@ -1074,7 +1075,7 @@ static int __devinit pc87360_probe(struct 
platform_device *pdev)
     mutex_init(&data->update_lock);
     platform_set_drvdata(pdev, data);
 
-    for (i = 0; i < 3; i++) {
+    for (i = 0; i < LDNI_MAX; i++) {
         if (((data->address[i] = extra_isa[i]))
          && !request_region(extra_isa[i], PC87360_EXTENT,
                      pc87360_driver.driver.name)) {
-- 
1.5.5.1



[-- Attachment #2: 0004-hwmon-pc87360-separate-alarm-files-define-LDNI_MAX.patch --]
[-- Type: text/x-patch, Size: 1374 bytes --]

From e1750cd32128cc7a17dfc15f3920f3d184b8bbff Mon Sep 17 00:00:00 2001
From: Jim Cromie <jim.cromie@gmail.com>
Date: Sat, 28 Jun 2008 13:40:50 -0600
Subject: [PATCH] hwmon/pc87360 separate alarm files - define LDNI_MAX const

Driver handles 3 logical devices in fixed length array.
Give this a define-d constant.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 drivers/hwmon/pc87360.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
index 6ffea41..ebb235b 100644
--- a/drivers/hwmon/pc87360.c
+++ b/drivers/hwmon/pc87360.c
@@ -75,7 +75,8 @@ MODULE_PARM_DESC(force_id, "Override the detected device ID");
 #define FSCM	0x09	/* Logical device: fans */
 #define VLM	0x0d	/* Logical device: voltages */
 #define TMS	0x0e	/* Logical device: temperatures */
-static const u8 logdev[3] = { FSCM, VLM, TMS };
+#define LDNI_MAX 3
+static const u8 logdev[LDNI_MAX] = { FSCM, VLM, TMS };
 
 #define LD_FAN		0
 #define LD_IN		1
@@ -1074,7 +1075,7 @@ static int __devinit pc87360_probe(struct platform_device *pdev)
 	mutex_init(&data->update_lock);
 	platform_set_drvdata(pdev, data);
 
-	for (i = 0; i < 3; i++) {
+	for (i = 0; i < LDNI_MAX; i++) {
 		if (((data->address[i] = extra_isa[i]))
 		 && !request_region(extra_isa[i], PC87360_EXTENT,
 		 		    pc87360_driver.driver.name)) {
-- 
1.5.5.1


[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [lm-sensors] [patch 2.6.27-rc6 4/6 ] hwmon/pc87360 separate
  2008-09-10  9:37 [lm-sensors] [patch 2.6.27-rc6 4/6 ] hwmon/pc87360 separate sysfs Jim Cromie
@ 2008-09-11  0:03 ` Andrew Morton
  2008-09-11  3:52 ` Jim Cromie
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2008-09-11  0:03 UTC (permalink / raw)
  To: lm-sensors

On Wed, 10 Sep 2008 03:37:44 -0600
Jim Cromie <jim.cromie@gmail.com> wrote:

> Driver handles 3 logical devices in fixed length array.
> Give this a define-d constant.
> 
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> ---
>  drivers/hwmon/pc87360.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
> index 6ffea41..ebb235b 100644
> --- a/drivers/hwmon/pc87360.c
> +++ b/drivers/hwmon/pc87360.c
> @@ -75,7 +75,8 @@ MODULE_PARM_DESC(force_id, "Override the detected 
> device ID");
>  #define FSCM    0x09    /* Logical device: fans */
>  #define VLM    0x0d    /* Logical device: voltages */
>  #define TMS    0x0e    /* Logical device: temperatures */
> -static const u8 logdev[3] = { FSCM, VLM, TMS };
> +#define LDNI_MAX 3
> +static const u8 logdev[LDNI_MAX] = { FSCM, VLM, TMS };
>  
>  #define LD_FAN        0
>  #define LD_IN        1
> @@ -1074,7 +1075,7 @@ static int __devinit pc87360_probe(struct 
> platform_device *pdev)
>      mutex_init(&data->update_lock);
>      platform_set_drvdata(pdev, data);
>  
> -    for (i = 0; i < 3; i++) {
> +    for (i = 0; i < LDNI_MAX; i++) {
>          if (((data->address[i] = extra_isa[i]))
>           && !request_region(extra_isa[i], PC87360_EXTENT,
>                       pc87360_driver.driver.name)) {

Is this better than doing

static const u8 logdev[3] = { FSCM, VLM, TMS };

	for (i = 0; i < ARRAY_SIZE(logdev); i++) {


?

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [lm-sensors] [patch 2.6.27-rc6 4/6 ] hwmon/pc87360 separate
  2008-09-10  9:37 [lm-sensors] [patch 2.6.27-rc6 4/6 ] hwmon/pc87360 separate sysfs Jim Cromie
  2008-09-11  0:03 ` [lm-sensors] [patch 2.6.27-rc6 4/6 ] hwmon/pc87360 separate Andrew Morton
@ 2008-09-11  3:52 ` Jim Cromie
  1 sibling, 0 replies; 3+ messages in thread
From: Jim Cromie @ 2008-09-11  3:52 UTC (permalink / raw)
  To: lm-sensors

Andrew Morton wrote:
> On Wed, 10 Sep 2008 03:37:44 -0600
> Jim Cromie <jim.cromie@gmail.com> wrote:
>
>   
>> Driver handles 3 logical devices in fixed length array.
>> Give this a define-d constant.
>>
>> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
>> ---
>>  drivers/hwmon/pc87360.c |    5 +++--
>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwmon/pc87360.c b/drivers/hwmon/pc87360.c
>> index 6ffea41..ebb235b 100644
>> --- a/drivers/hwmon/pc87360.c
>> +++ b/drivers/hwmon/pc87360.c
>> @@ -75,7 +75,8 @@ MODULE_PARM_DESC(force_id, "Override the detected 
>> device ID");
>>  #define FSCM    0x09    /* Logical device: fans */
>>  #define VLM    0x0d    /* Logical device: voltages */
>>  #define TMS    0x0e    /* Logical device: temperatures */
>> -static const u8 logdev[3] = { FSCM, VLM, TMS };
>> +#define LDNI_MAX 3
>> +static const u8 logdev[LDNI_MAX] = { FSCM, VLM, TMS };
>>  
>>  #define LD_FAN        0
>>  #define LD_IN        1
>> @@ -1074,7 +1075,7 @@ static int __devinit pc87360_probe(struct 
>> platform_device *pdev)
>>      mutex_init(&data->update_lock);
>>      platform_set_drvdata(pdev, data);
>>  
>> -    for (i = 0; i < 3; i++) {
>> +    for (i = 0; i < LDNI_MAX; i++) {
>>          if (((data->address[i] = extra_isa[i]))
>>           && !request_region(extra_isa[i], PC87360_EXTENT,
>>                       pc87360_driver.driver.name)) {
>>     
>
> Is this better than doing
>
> static const u8 logdev[3] = { FSCM, VLM, TMS };
>
> 	for (i = 0; i < ARRAY_SIZE(logdev); i++) {
>
>
> ?
>
>   
No, not really.
Ive reworked the patch your way, minus the unnecessary '3'

And rebased the patchset.
Im pleased (but not really surprised) that re-rebasing on same -r6 
commit worked.

sending new patchset shortly.

thanks

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-11  3:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-10  9:37 [lm-sensors] [patch 2.6.27-rc6 4/6 ] hwmon/pc87360 separate sysfs Jim Cromie
2008-09-11  0:03 ` [lm-sensors] [patch 2.6.27-rc6 4/6 ] hwmon/pc87360 separate Andrew Morton
2008-09-11  3:52 ` Jim Cromie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.