From: Avi Kivity <avi@qumranet.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: KVM: x86: do not execute halted vcpus (resend)
Date: Wed, 10 Sep 2008 15:04:10 +0300 [thread overview]
Message-ID: <48C7B7BA.70405@qumranet.com> (raw)
In-Reply-To: <48C68502.9010500@qumranet.com>
Avi Kivity wrote:
> Marcelo Tosatti wrote:
>> Offline or uninitialized vcpu's can be executed if requested to perform
>> userspace work.
>> Follow Avi's suggestion to handle halted vcpu's in the main loop,
>> simplifying kvm_emulate_halt(). Introduce a new vcpu->requests bit to
>> indicate events that promote state from halted to running.
>>
>> Also standardize vcpu wake sites.
>>
>> Avi, please confirm that this does not break Windows reboot (which I
>> can't
>> reproduce).
>>
>
> I couldn't reproduce it either (probably mistested earlier), so I
> applied it. Sorry about the drops.
>
Actually it does reproduce. If you reboot twice, the second reboot will
hang during reset (with cs:ip = f000:fff0). Plain Windows XP.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-09-10 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 18:23 KVM: x86: do not execute halted vcpus (resend) Marcelo Tosatti
2008-09-09 14:15 ` Avi Kivity
2008-09-10 12:04 ` Avi Kivity [this message]
2008-09-10 18:37 ` Marcelo Tosatti
2008-09-10 18:42 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2008-09-10 19:40 Marcelo Tosatti
2008-09-11 8:07 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C7B7BA.70405@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.