Re: KVM: x86: do not execute halted vcpus (resend)

[Avi Kivity <avi@qumranet.com>]

Marcelo Tosatti wrote:
>> Actually it does reproduce.  If you reboot twice, the second reboot will  
>> hang during reset (with cs:ip = f000:fff0).  Plain Windows XP.
>>     
>
> OK, easily reproducible by adding a sleep at the start of
> qemu_kvm_system_reset.
>
> The problem is that the vcpu HLT's between the KBD ioport write and the
> actual system reset by the IO thread. By then time there will be no
> event that takes it out of STATE_HALTED.
>
> The following fixes it, however older userspace will remain borked.
> Alternative is to special case f000:fff0 in-kernel. What is preferred?
>
>   

Special-case the kvm_set_sregs ioctl with cs:eip f000:fff0 (and cr0.pe=0
for good measure).

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.