From: Max Krasnyansky <maxk@kernel.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: aurelien@aurel32.net, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH] usb: Support for removing device by host addr, improved auto filter syntax
Date: Thu, 11 Sep 2008 20:48:52 -0700 [thread overview]
Message-ID: <48C9E6A4.1070402@kernel.org> (raw)
In-Reply-To: <48C98738.5060204@codemonkey.ws>
Anthony Liguori wrote:
> Max Krasnyansky wrote:
>> This patch adds support for removing USB devices by host address.
>> Which is usefull for things like libvirtd because there is no easy way to
>> find guest USB address of the host device.
>> In other words you can now do:
>> usb_add host:3.5
>> ...
>> usb_del host:3.5
>> Before the patch 'usb_del' did not support 'host:' notation.
>>
>>
>
> This patch breaks the windows build with:
>
> i686-pc-mingw32-gcc -Wall -O2 -g -fno-strict-aliasing -m32 -I.
> -I/home/anthony/svn/qemu -MMD -MP -MT usb-linux.o -D_GNU_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> -I/home/anthony/svn/qemu/slirp -c -o usb-linux.o
> /home/anthony/svn/qemu/usb-linux.c
> /home/anthony/svn/qemu/usb-linux.c:1205: error: conflicting types for
> 'usb_host_device_close'
> /home/anthony/svn/qemu/hw/usb.h:243: error: previous declaration of
> 'usb_host_device_close' was here
> make: *** [usb-linux.o] Error 1
I'll take a look and resend. Thanx for testing.
Max
WARNING: multiple messages have this Message-ID (diff)
From: Max Krasnyansky <maxk@kernel.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH] usb: Support for removing device by host addr, improved auto filter syntax
Date: Thu, 11 Sep 2008 20:48:52 -0700 [thread overview]
Message-ID: <48C9E6A4.1070402@kernel.org> (raw)
In-Reply-To: <48C98738.5060204@codemonkey.ws>
Anthony Liguori wrote:
> Max Krasnyansky wrote:
>> This patch adds support for removing USB devices by host address.
>> Which is usefull for things like libvirtd because there is no easy way to
>> find guest USB address of the host device.
>> In other words you can now do:
>> usb_add host:3.5
>> ...
>> usb_del host:3.5
>> Before the patch 'usb_del' did not support 'host:' notation.
>>
>>
>
> This patch breaks the windows build with:
>
> i686-pc-mingw32-gcc -Wall -O2 -g -fno-strict-aliasing -m32 -I.
> -I/home/anthony/svn/qemu -MMD -MP -MT usb-linux.o -D_GNU_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> -I/home/anthony/svn/qemu/slirp -c -o usb-linux.o
> /home/anthony/svn/qemu/usb-linux.c
> /home/anthony/svn/qemu/usb-linux.c:1205: error: conflicting types for
> 'usb_host_device_close'
> /home/anthony/svn/qemu/hw/usb.h:243: error: previous declaration of
> 'usb_host_device_close' was here
> make: *** [usb-linux.o] Error 1
I'll take a look and resend. Thanx for testing.
Max
next prev parent reply other threads:[~2008-09-12 3:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-06 5:40 [PATCH] usb: Support for removing device by host addr, improved auto filter syntax Max Krasnyansky
2008-09-06 5:40 ` [Qemu-devel] " Max Krasnyansky
2008-09-11 21:01 ` Anthony Liguori
2008-09-11 21:01 ` [Qemu-devel] " Anthony Liguori
2008-09-12 3:48 ` Max Krasnyansky [this message]
2008-09-12 3:48 ` Max Krasnyansky
-- strict thread matches above, loose matches on Subject: below --
2008-09-13 22:01 Max Krasnyansky
2008-09-14 1:11 ` Anthony Liguori
2008-09-14 17:15 ` Max Krasnyansky
2008-09-17 15:48 ` Andreas Winkelbauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C9E6A4.1070402@kernel.org \
--to=maxk@kernel.org \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.