* [PATCH 1/2] ehea: Fix DLPAR memory handling
@ 2008-09-05 14:36 ` Hannes Hering
0 siblings, 0 replies; 4+ messages in thread
From: Hannes Hering @ 2008-09-05 14:36 UTC (permalink / raw)
To: jeff
Cc: themann, netdev, linux-kernel, raisch, ossrosch, linuxppc-dev,
ossthema, osstklei
The ehea busmap must be allocated only once in the first of many calls of the
ehea_create_busmap_callback.
Signed-off-by: Hannes Hering <hering2@de.ibm.com>
---
diff -Nurp -X dontdiff linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c patched_kernel/drivers/net/ehea/ehea_qmr.c
--- linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c 2008-08-29 00:52:02.000000000 +0200
+++ patched_kernel/drivers/net/ehea/ehea_qmr.c 2008-09-05 15:31:30.000000000 +0200
@@ -595,7 +595,8 @@ static int ehea_create_busmap_callback(u
end_section = start_section + ((nr_pages * PAGE_SIZE) / EHEA_SECTSIZE);
mr_len = *(unsigned long *)arg;
- ehea_bmap = kzalloc(sizeof(struct ehea_bmap), GFP_KERNEL);
+ if (!ehea_bmap)
+ ehea_bmap = kzalloc(sizeof(struct ehea_bmap), GFP_KERNEL);
if (!ehea_bmap)
return -ENOMEM;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] ehea: Fix DLPAR memory handling
@ 2008-09-05 14:36 ` Hannes Hering
0 siblings, 0 replies; 4+ messages in thread
From: Hannes Hering @ 2008-09-05 14:36 UTC (permalink / raw)
To: jeff
Cc: linux-kernel, linuxppc-dev, netdev, ossrosch, ossthema, raisch,
themann, osstklei
The ehea busmap must be allocated only once in the first of many calls of the
ehea_create_busmap_callback.
Signed-off-by: Hannes Hering <hering2@de.ibm.com>
---
diff -Nurp -X dontdiff linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c patched_kernel/drivers/net/ehea/ehea_qmr.c
--- linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c 2008-08-29 00:52:02.000000000 +0200
+++ patched_kernel/drivers/net/ehea/ehea_qmr.c 2008-09-05 15:31:30.000000000 +0200
@@ -595,7 +595,8 @@ static int ehea_create_busmap_callback(u
end_section = start_section + ((nr_pages * PAGE_SIZE) / EHEA_SECTSIZE);
mr_len = *(unsigned long *)arg;
- ehea_bmap = kzalloc(sizeof(struct ehea_bmap), GFP_KERNEL);
+ if (!ehea_bmap)
+ ehea_bmap = kzalloc(sizeof(struct ehea_bmap), GFP_KERNEL);
if (!ehea_bmap)
return -ENOMEM;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ehea: Fix DLPAR memory handling
2008-09-05 14:36 ` Hannes Hering
@ 2008-09-13 19:55 ` Jeff Garzik
-1 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2008-09-13 19:55 UTC (permalink / raw)
To: Hannes Hering
Cc: themann, netdev, linux-kernel, raisch, ossrosch, linuxppc-dev,
ossthema, osstklei
Hannes Hering wrote:
> The ehea busmap must be allocated only once in the first of many calls of the
> ehea_create_busmap_callback.
>
> Signed-off-by: Hannes Hering <hering2@de.ibm.com>
> ---
>
> diff -Nurp -X dontdiff linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c patched_kernel/drivers/net/ehea/ehea_qmr.c
> --- linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c 2008-08-29 00:52:02.000000000 +0200
> +++ patched_kernel/drivers/net/ehea/ehea_qmr.c 2008-09-05 15:31:30.000000000 +0200
> @@ -595,7 +595,8 @@ static int ehea_create_busmap_callback(u
> end_section = start_section + ((nr_pages * PAGE_SIZE) / EHEA_SECTSIZE);
> mr_len = *(unsigned long *)arg;
>
> - ehea_bmap = kzalloc(sizeof(struct ehea_bmap), GFP_KERNEL);
> + if (!ehea_bmap)
> + ehea_bmap = kzalloc(sizeof(struct ehea_bmap), GFP_KERNEL);
> if (!ehea_bmap)
> return -ENOMEM;
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ehea: Fix DLPAR memory handling
@ 2008-09-13 19:55 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2008-09-13 19:55 UTC (permalink / raw)
To: Hannes Hering
Cc: linux-kernel, linuxppc-dev, netdev, ossrosch, ossthema, raisch,
themann, osstklei
Hannes Hering wrote:
> The ehea busmap must be allocated only once in the first of many calls of the
> ehea_create_busmap_callback.
>
> Signed-off-by: Hannes Hering <hering2@de.ibm.com>
> ---
>
> diff -Nurp -X dontdiff linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c patched_kernel/drivers/net/ehea/ehea_qmr.c
> --- linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c 2008-08-29 00:52:02.000000000 +0200
> +++ patched_kernel/drivers/net/ehea/ehea_qmr.c 2008-09-05 15:31:30.000000000 +0200
> @@ -595,7 +595,8 @@ static int ehea_create_busmap_callback(u
> end_section = start_section + ((nr_pages * PAGE_SIZE) / EHEA_SECTSIZE);
> mr_len = *(unsigned long *)arg;
>
> - ehea_bmap = kzalloc(sizeof(struct ehea_bmap), GFP_KERNEL);
> + if (!ehea_bmap)
> + ehea_bmap = kzalloc(sizeof(struct ehea_bmap), GFP_KERNEL);
> if (!ehea_bmap)
> return -ENOMEM;
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-09-13 19:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-05 14:36 [PATCH 1/2] ehea: Fix DLPAR memory handling Hannes Hering
2008-09-05 14:36 ` Hannes Hering
2008-09-13 19:55 ` Jeff Garzik
2008-09-13 19:55 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.