All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@nokia.com>
To: ext Hardik Shah <hardik.shah@ti.com>
Cc: linux-omap@vger.kernel.org, video4linux-list@redhat.com,
	linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] OMAP 2/3 V4L2 display driver on video planes
Date: Wed, 17 Sep 2008 18:30:05 +0300	[thread overview]
Message-ID: <48D1227D.5070207@nokia.com> (raw)
In-Reply-To: <1221663942-7160-1-git-send-email-hardik.shah@ti.com>

Hi, Hardik!

ext Hardik Shah wrote:
> diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
> index 2703c66..e899dd2 100644
> --- a/drivers/media/video/Kconfig
> +++ b/drivers/media/video/Kconfig
> @@ -762,8 +762,6 @@ source "drivers/media/video/au0828/Kconfig"
> 
>  source "drivers/media/video/ivtv/Kconfig"
> 
> -source drivers/media/video/omap/Kconfig
> -
>  source "drivers/media/video/cx18/Kconfig"
> 
>  config VIDEO_M32R_AR
> @@ -802,6 +800,14 @@ config VIDEO_OMAP2
>  	---help---
>  	  Driver for an OMAP 2 camera controller.
> 
> +config VIDEO_OMAP3

This is the same configuration option as we are using for the OMAP 3 
camera driver at the moment.

Could you, for example, call this VIDEO_OMAP3_VIDEOOUT?

CONFIG_VIDEO_OMAP2 enables the OMAP 2 camera driver.

> diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
> index 3e580e8..10f879c 100644
> --- a/drivers/media/video/Makefile
> +++ b/drivers/media/video/Makefile
> @@ -107,6 +107,8 @@ obj-$(CONFIG_VIDEO_CAFE_CCIC) += cafe_ccic.o
>  obj-$(CONFIG_VIDEO_OV7670) 	+= ov7670.o
> 
>  obj-$(CONFIG_VIDEO_OMAP2) += omap24xxcam.o omap24xxcam-dma.o
> +obj-$(CONFIG_VIDEO_OMAP3) += omap/

It's just two C source code files --- how about putting them into the 
parent directory? The omap directory has just one driver in it, the OMAP 
1 camera driver. I think at some point it was intended to be moved to 
the parent directory although this hasn't happened.

Best regards,

-- 
Sakari Ailus
sakari.ailus@nokia.com

WARNING: multiple messages have this Message-ID (diff)
From: Sakari Ailus <sakari.ailus@nokia.com>
To: ext Hardik Shah <hardik.shah@ti.com>
Cc: video4linux-list@redhat.com, linux-omap@vger.kernel.org,
	linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] OMAP 2/3 V4L2 display driver on video planes
Date: Wed, 17 Sep 2008 18:30:05 +0300	[thread overview]
Message-ID: <48D1227D.5070207@nokia.com> (raw)
In-Reply-To: <1221663942-7160-1-git-send-email-hardik.shah@ti.com>

Hi, Hardik!

ext Hardik Shah wrote:
> diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
> index 2703c66..e899dd2 100644
> --- a/drivers/media/video/Kconfig
> +++ b/drivers/media/video/Kconfig
> @@ -762,8 +762,6 @@ source "drivers/media/video/au0828/Kconfig"
> 
>  source "drivers/media/video/ivtv/Kconfig"
> 
> -source drivers/media/video/omap/Kconfig
> -
>  source "drivers/media/video/cx18/Kconfig"
> 
>  config VIDEO_M32R_AR
> @@ -802,6 +800,14 @@ config VIDEO_OMAP2
>  	---help---
>  	  Driver for an OMAP 2 camera controller.
> 
> +config VIDEO_OMAP3

This is the same configuration option as we are using for the OMAP 3 
camera driver at the moment.

Could you, for example, call this VIDEO_OMAP3_VIDEOOUT?

CONFIG_VIDEO_OMAP2 enables the OMAP 2 camera driver.

> diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
> index 3e580e8..10f879c 100644
> --- a/drivers/media/video/Makefile
> +++ b/drivers/media/video/Makefile
> @@ -107,6 +107,8 @@ obj-$(CONFIG_VIDEO_CAFE_CCIC) += cafe_ccic.o
>  obj-$(CONFIG_VIDEO_OV7670) 	+= ov7670.o
> 
>  obj-$(CONFIG_VIDEO_OMAP2) += omap24xxcam.o omap24xxcam-dma.o
> +obj-$(CONFIG_VIDEO_OMAP3) += omap/

It's just two C source code files --- how about putting them into the 
parent directory? The omap directory has just one driver in it, the OMAP 
1 camera driver. I think at some point it was intended to be moved to 
the parent directory although this hasn't happened.

Best regards,

-- 
Sakari Ailus
sakari.ailus@nokia.com

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2008-09-17 15:30 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-17 15:05 [PATCH] OMAP 2/3 V4L2 display driver on video planes Hardik Shah
2008-09-17 15:05 ` Hardik Shah
2008-09-17 15:30 ` Sakari Ailus [this message]
2008-09-17 15:30   ` Sakari Ailus
2008-09-17 15:42   ` Hiremath, Vaibhav
2008-09-17 15:42     ` Hiremath, Vaibhav
2008-10-03 14:33 ` Hans Verkuil
2008-10-03 14:33   ` Hans Verkuil
2008-10-03 14:40   ` Shah, Hardik
2008-10-03 14:40     ` Shah, Hardik
2008-10-05 11:19     ` Mauro Carvalho Chehab
2008-10-05 11:19       ` Mauro Carvalho Chehab
2008-10-05 11:57       ` Robert William Fuller
2008-10-05 11:57         ` Robert William Fuller
2008-10-05 12:05         ` Mauro Carvalho Chehab
2008-10-05 12:05           ` Mauro Carvalho Chehab
2008-10-07 21:48         ` [Linux-fbdev-devel] " Krzysztof Helt
2008-10-06  6:06       ` Shah, Hardik
2008-10-06  6:06         ` Shah, Hardik
2008-10-06  6:29         ` Hans Verkuil
2008-10-06  8:41           ` Måns Rullgård
2008-10-06  8:50           ` Shah, Hardik
2008-10-06  8:50             ` Shah, Hardik
2008-10-06 11:22             ` [Linux-fbdev-devel] " Geert Uytterhoeven
2008-10-16  5:35           ` Shah, Hardik
2008-10-16  6:27             ` Hans Verkuil
2008-10-24  9:50           ` Shah, Hardik
2008-10-24  9:50             ` Shah, Hardik
     [not found] <8bf247760810152337w62c47f8ideaf355a0ed08771@mail.gmail.com>
2008-10-16  7:09 ` Shah, Hardik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D1227D.5070207@nokia.com \
    --to=sakari.ailus@nokia.com \
    --cc=hardik.shah@ti.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-omap@vger.kernel.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.