From: Jeff Garzik <jeff@garzik.org>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@linux-foundation.org, davem@davemloft.net
Subject: Re: warn: Turn the netdev timeout WARN_ON() into a WARN()
Date: Wed, 17 Sep 2008 17:53:45 -0400 [thread overview]
Message-ID: <48D17C69.6060203@garzik.org> (raw)
In-Reply-To: <20080917144558.6ed2e6b8@linux.intel.com>
Arjan van de Ven wrote:
> I cannot disagree with the "the backtrace is not useful" statement for
> this case. I don't even mind making a WARN() variant that doesn't
> backtrace; I'll look into that. I don't consider it "2.6.27 urgent"
> though; a backtrace is pretty light to do for such an exceptional
> slowpath case, and the only real effect is a few lines
> in /var/log/messages that are somewhat redundant.
Quite agreed -- I never meant to imply that [second half of my reply]
was urgent, just giving some food for thought about improving the system.
Jeff
prev parent reply other threads:[~2008-09-17 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200809170259.m8H2xClI020907@hera.kernel.org>
2008-09-17 3:27 ` warn: Turn the netdev timeout WARN_ON() into a WARN() Jeff Garzik
2008-09-17 13:41 ` Arjan van de Ven
2008-09-17 21:39 ` Jeff Garzik
2008-09-17 21:45 ` Arjan van de Ven
2008-09-17 21:53 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D17C69.6060203@garzik.org \
--to=jeff@garzik.org \
--cc=arjan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.