All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Avi Kivity <avi@redhat.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	Hugh Dickens <hugh@veritas.com>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Avi Kivity <avi@qumranet.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>
Subject: Re: Populating multiple ptes at fault time
Date: Wed, 17 Sep 2008 16:02:03 -0700	[thread overview]
Message-ID: <48D18C6B.5010407@goop.org> (raw)
In-Reply-To: <48D18919.9060808@redhat.com>

Avi Kivity wrote:
> We could work around it by having a hypercall to read and clear
> accessed bits.  If we know the guest will only do that via the
> hypercall, we can keep the accessed (and dirty) bits in the host, and
> not update them in the guest at all.  Given good batching, there's
> potential for a large win there.

We added a hypercall to update just the AD bits, though it was primarily
to update D without losing the hardware-set A bit.

I don't think it would be practical to add a hypercall to read the A
bit.  There's too much code which just assumes it can grab a pte and
test the bit state.  There's no pv_op for reading a pte in general, and
even if there were you'd need to have a specialized pv-op for
specifically reading the A bit to avoid unnecessary hypercalls.

Setting/clearing the A bit could be done via the normal set_pte pv_op,
so that's not a big deal.

Do you need to set the A bit synchronously?  What happens if you install
the guest and shadow pte with A clear, and then lazily transfer the A
bit state from the shadow to guest pte?  Maybe at some significant event
like  a tlb flush or:

> (If the host throws away a shadow page, it could sync the bits back
> into the guest pte for safekeeping)


    J

WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Avi Kivity <avi@redhat.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	Hugh Dickens <hugh@veritas.com>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Avi Kivity <avi@qumranet.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>
Subject: Re: Populating multiple ptes at fault time
Date: Wed, 17 Sep 2008 16:02:03 -0700	[thread overview]
Message-ID: <48D18C6B.5010407@goop.org> (raw)
In-Reply-To: <48D18919.9060808@redhat.com>

Avi Kivity wrote:
> We could work around it by having a hypercall to read and clear
> accessed bits.  If we know the guest will only do that via the
> hypercall, we can keep the accessed (and dirty) bits in the host, and
> not update them in the guest at all.  Given good batching, there's
> potential for a large win there.

We added a hypercall to update just the AD bits, though it was primarily
to update D without losing the hardware-set A bit.

I don't think it would be practical to add a hypercall to read the A
bit.  There's too much code which just assumes it can grab a pte and
test the bit state.  There's no pv_op for reading a pte in general, and
even if there were you'd need to have a specialized pv-op for
specifically reading the A bit to avoid unnecessary hypercalls.

Setting/clearing the A bit could be done via the normal set_pte pv_op,
so that's not a big deal.

Do you need to set the A bit synchronously?  What happens if you install
the guest and shadow pte with A clear, and then lazily transfer the A
bit state from the shadow to guest pte?  Maybe at some significant event
like  a tlb flush or:

> (If the host throws away a shadow page, it could sync the bits back
> into the guest pte for safekeeping)


    J

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-09-17 23:02 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-17 17:47 Populating multiple ptes at fault time Jeremy Fitzhardinge
2008-09-17 17:47 ` Jeremy Fitzhardinge
2008-09-17 18:28 ` Rik van Riel
2008-09-17 18:28   ` Rik van Riel
2008-09-17 21:47   ` Jeremy Fitzhardinge
2008-09-17 21:47     ` Jeremy Fitzhardinge
2008-09-17 20:02 ` Chris Snook
2008-09-17 20:02   ` Chris Snook
2008-09-17 21:45   ` Jeremy Fitzhardinge
2008-09-17 21:45     ` Jeremy Fitzhardinge
2008-09-18 18:16     ` Christoph Lameter
2008-09-18 18:16       ` Christoph Lameter
2008-09-18 18:53       ` Jeremy Fitzhardinge
2008-09-18 18:53         ` Jeremy Fitzhardinge
2008-09-18 19:39         ` Christoph Lameter
2008-09-18 19:39           ` Christoph Lameter
2008-09-18 22:21           ` KOSAKI Motohiro
2008-09-18 22:21             ` KOSAKI Motohiro
2008-09-18 20:52         ` Martin Bligh
2008-09-18 20:52           ` Martin Bligh
2008-09-18 20:53           ` Chris Snook
2008-09-18 20:53             ` Chris Snook
2008-09-18 21:11             ` Martin Bligh
2008-09-18 21:11               ` Martin Bligh
2008-09-18 21:13               ` Christoph Lameter
2008-09-18 21:13                 ` Christoph Lameter
2008-09-18 21:21                 ` Martin Bligh
2008-09-18 21:21                   ` Martin Bligh
2008-09-18 21:32                   ` Christoph Lameter
2008-09-18 21:32                     ` Christoph Lameter
2008-09-18 21:49                     ` MinChan Kim
2008-09-18 21:49                       ` MinChan Kim
2008-09-18 21:58                       ` Christoph Lameter
2008-09-18 21:58                         ` Christoph Lameter
2008-09-18 22:08                         ` Martin Bligh
2008-09-18 22:08                           ` Martin Bligh
2008-09-18 22:11                           ` Christoph Lameter
2008-09-18 22:11                             ` Christoph Lameter
2008-09-18 22:18                             ` Martin Bligh
2008-09-18 22:18                               ` Martin Bligh
2008-09-18 22:22                               ` Jeremy Fitzhardinge
2008-09-18 22:22                                 ` Jeremy Fitzhardinge
2008-09-18 22:23                             ` Chris Snook
2008-09-18 22:23                               ` Chris Snook
2008-09-18 23:16                               ` MinChan Kim
2008-09-18 23:16                                 ` MinChan Kim
2008-09-17 22:02 ` Avi Kivity
2008-09-17 22:02   ` Avi Kivity
2008-09-17 22:30   ` Jeremy Fitzhardinge
2008-09-17 22:30     ` Jeremy Fitzhardinge
2008-09-17 22:47     ` Avi Kivity
2008-09-17 22:47       ` Avi Kivity
2008-09-17 23:02       ` Jeremy Fitzhardinge [this message]
2008-09-17 23:02         ` Jeremy Fitzhardinge
2008-09-18 20:26         ` Avi Kivity
2008-09-18 20:26           ` Avi Kivity
2008-09-18 22:18           ` Jeremy Fitzhardinge
2008-09-18 22:18             ` Jeremy Fitzhardinge
2008-09-18 23:38             ` Avi Kivity
2008-09-18 23:38               ` Avi Kivity
2008-09-19  0:00               ` Jeremy Fitzhardinge
2008-09-19  0:00                 ` Jeremy Fitzhardinge
2008-09-19  0:20                 ` Avi Kivity
2008-09-19  0:20                   ` Avi Kivity
2008-09-19  0:42                   ` Jeremy Fitzhardinge
2008-09-19  0:42                     ` Jeremy Fitzhardinge
2008-09-24 12:31                     ` Avi Kivity
2008-09-24 12:31                       ` Avi Kivity
2008-09-25 18:32                       ` Jeremy Fitzhardinge
2008-09-25 18:32                         ` Jeremy Fitzhardinge
2008-09-26 10:26                         ` Martin Schwidefsky
2008-09-26 10:26                           ` Martin Schwidefsky
2008-09-19 17:45   ` Benjamin Herrenschmidt
2008-09-19 17:45     ` Benjamin Herrenschmidt
2008-09-17 23:50 ` MinChan Kim
2008-09-17 23:50   ` MinChan Kim
2008-09-18  6:58   ` KOSAKI Motohiro
2008-09-18  6:58     ` KOSAKI Motohiro
2008-09-18  7:26   ` KAMEZAWA Hiroyuki
2008-09-18  7:26     ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D18C6B.5010407@goop.org \
    --to=jeremy@goop.org \
    --cc=akpm@linux-foundation.org \
    --cc=avi@qumranet.com \
    --cc=avi@redhat.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.