From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: Ingo Molnar <mingo@elte.hu>,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v3)
Date: Thu, 18 Sep 2008 10:25:11 -0700 [thread overview]
Message-ID: <48D28EF7.4080504@zytor.com> (raw)
In-Reply-To: <48D29554.76E4.0078.0@novell.com>
Jan Beulich wrote:
>>
>> There is no reason for this to be #ifdef'd; but it should be conditional
>> on this information not being otherwise available (which will always be
>> the case on 64 bits), I would assume. If we are setting a value there,
>> we should presumably also set 32 in the other case.
>
> It does get set to 32 first (and only for 32-bits - 64bits didn't set any
> default so far, so I didn't want to make it to now), and the code fragment
> above updates that default after feature flags have been obtained, but
> before other capabilities (including the phys/virt bit widths) are being
> gathered.
>
Set the default on 64 bits as well. It's cleaner to not leave a
pointless #ifdef in there.
-hpa
next prev parent reply other threads:[~2008-09-18 17:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 7:13 [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v3) Jan Beulich
2008-09-18 7:18 ` Ingo Molnar
2008-09-18 9:10 ` Ingo Molnar
2008-09-18 9:31 ` Jan Beulich
2008-09-18 9:57 ` Ingo Molnar
2008-09-18 11:20 ` Ingo Molnar
2008-09-18 11:58 ` Jan Beulich
2008-09-18 12:29 ` Ingo Molnar
2008-09-18 18:00 ` Jeremy Fitzhardinge
2008-09-18 18:12 ` H. Peter Anvin
2008-09-19 8:32 ` Jan Beulich
2008-09-19 21:46 ` Jeremy Fitzhardinge
2008-09-19 23:32 ` H. Peter Anvin
2008-09-18 15:25 ` H. Peter Anvin
2008-09-18 15:52 ` Jan Beulich
2008-09-18 17:25 ` H. Peter Anvin [this message]
2008-09-18 7:52 ` Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2008-09-05 12:07 [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v2) Jan Beulich
2008-09-05 15:00 ` Ingo Molnar
2008-09-08 10:50 ` Jan Beulich
2008-09-08 13:40 ` Ingo Molnar
2008-09-08 18:54 ` Ingo Molnar
2008-09-09 7:43 ` [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v3) Jan Beulich
2008-09-09 7:47 ` Ingo Molnar
2008-09-09 7:58 ` Ingo Molnar
2008-09-09 8:15 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D28EF7.4080504@zytor.com \
--to=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.