Re: [PATCH] Add __enable_execute_stack() if required

[Christian Franke <Christian.Franke@t-online.de>]

walt wrote:
> Robert Millan wrote:
>> On Tue, Sep 16, 2008 at 09:42:50PM +0200, Christian Franke wrote:
>>> Some gcc versions generate a call to __enable_execute_stack() in
>>> trampolines for nested functions. This is the case for new Cygwin 
>>> gcc-4.3.2.
>>>
>>> Other GRUB2 target platforms may be affected - the following files in
>>> 'gcc-4.3.2/gcc/config' source directory contains implementations of 
>>> this
>>> function for libgcc:
>>>
>>> alpha/osf.h
>>> darwin.h
>>> netbsd.h
>>
>> I recall this was also an issue for NetBSD indeed.  Could someone 
>> confirm it
>> fixes the problem there?
>
> It does fix the problem on NetBSD, thanks Christian.
>

You're welcome. Thanks for testing.

Patch committed.

If more such functions are necessary in the future, it is probably 
better to collect those in some libgcc.a replacement module.
This would be the case if e.g. for the 64-bit integer division. On 
32-bit architectures, gcc typically generates a call to __divdi3().

Christian