All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Mark de Wever <koraq@xs4all.nl>
Cc: Gadi Oxman <gadio@netvision.net.il>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IDE-TAPE NULL terminate strings.
Date: Mon, 22 Sep 2008 00:08:27 +0400	[thread overview]
Message-ID: <48D6A9BB.1070705@ru.mvista.com> (raw)
In-Reply-To: <48D69F5A.9010201@ru.mvista.com>

Hello, I wrote:

>> After updating my kernel to 2.6.26 the output for the ide-tape drive
>> during booting is garbled eg
>> ide-tape: hdd <-> ht0: Seagate <98>ß8A51|1À<81>ܺ<98>ß STT20000A rev 
>> 8A51|1À<81>ܺ<98>ß

>> This patch fixes the problem by NULL terminating the strings.

>> Regards,
>> Mark de Wever

>> PS: please CC me since I'm not subscribed.
>> PPS: there are more problems with my tapestreamer in 2.6.26 but I'll
>> post a separate message for that.

>> Signed-off-by: Mark de Wever <koraq@xs4all.nl>

>> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
>> index 1bce84b..fd87b43 100644
>> --- a/drivers/ide/ide-tape.c
>> +++ b/drivers/ide/ide-tape.c
>> @@ -2354,6 +2354,10 @@ static void 
>> idetape_get_inquiry_results(ide_drive_t *drive)
>>      ide_fixstring(product_id, 18, 0);
>>      ide_fixstring(fw_rev, 6, 0);

    Hm, I see that every string variable declared there has 2 extra 
characters, and yet the author have managed to make a mistake... these extra 
chars don't seem needed.

MBR, Sergei

  reply	other threads:[~2008-09-21 20:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-21 18:51 [PATCH] IDE-TAPE NULL terminate strings Mark de Wever
2008-09-21 19:24 ` Sergei Shtylyov
2008-09-21 20:08   ` Sergei Shtylyov [this message]
2008-09-21 20:29     ` Mark de Wever
2008-09-21 22:12       ` Sergei Shtylyov
2008-09-22 13:16 ` Sergei Shtylyov
2008-09-22 13:56   ` Boris Petkov
2008-09-22 20:41     ` Mark de Wever
2008-09-22 21:08       ` Sergei Shtylyov
2008-09-23  7:48         ` Borislav Petkov
2008-09-23  9:29           ` Sergei Shtylyov
2008-09-23  9:29             ` Sergei Shtylyov
2008-09-23 13:40             ` Boris Petkov
2008-09-23 16:59           ` Mark de Wever
2008-09-23 16:59             ` Mark de Wever
2008-09-23 17:11             ` Boris Petkov
2008-09-23 21:20               ` IDE-TAPE regressions [was: [PATCH] IDE-TAPE NULL terminate strings.] Mark de Wever
2008-10-07 18:26                 ` [patch][repost] ide-tape build fix Mark de Wever
2008-10-08  6:33                   ` Borislav Petkov
2008-10-08 15:45                     ` Mark de Wever
2008-10-08 15:45                       ` Mark de Wever
2008-10-08 16:22                       ` Boris Petkov
2008-10-08 18:37                         ` Bartlomiej Zolnierkiewicz
2008-09-24  7:10             ` [PATCH] IDE-TAPE NULL terminate strings Borislav Petkov
2008-09-24  7:10               ` Borislav Petkov
2008-09-24  9:36               ` Sergei Shtylyov
2008-09-24  9:36                 ` Sergei Shtylyov
2008-09-27 17:04                 ` Bartlomiej Zolnierkiewicz
2008-09-23 16:14         ` Mark de Wever
2008-09-23 17:10           ` Sergei Shtylyov
2008-09-23 17:27             ` Mark de Wever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D6A9BB.1070705@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=bzolnier@gmail.com \
    --cc=gadio@netvision.net.il \
    --cc=koraq@xs4all.nl \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.