From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: petkovbb@gmail.com, Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Mark de Wever <koraq@xs4all.nl>,
Gadi Oxman <gadio@netvision.net.il>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>l
Subject: Re: [PATCH] IDE-TAPE NULL terminate strings.
Date: Tue, 23 Sep 2008 13:29:17 +0400 [thread overview]
Message-ID: <48D8B6ED.6020407@ru.mvista.com> (raw)
In-Reply-To: <20080923074845.GB5656@gollum.tnic>
Hello.
Borislav Petkov wrote:
>>> Only not sure whether the static is the best solution, the following
>>> patch also works, by zeroing the memory as you suggested.
>>>
>>> Signed-off-by: Mark de Wever <koraq@xs4all.nl>
>>>
>>> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
>>> index 1bce84b..c41f5b1 100644
>>> --- a/drivers/ide/ide-tape.c
>>> +++ b/drivers/ide/ide-tape.c
>>> @@ -2338,7 +2338,7 @@ static void idetape_get_inquiry_results(ide_drive_t *drive)
>>> {
>>> idetape_tape_t *tape = drive->driver_data;
>>> struct ide_atapi_pc pc;
>>> - char fw_rev[6], vendor_id[10], product_id[18];
>>> + char fw_rev[6] = {'\0'}, vendor_id[10] = {'\0'}, product_id[18] = {'\0'};
>>>
>>>
>> Do you realize how much *absolutely unnecessary* code will this bring
>> in? This is certainly worse than your initial patch (if it was correct).
>>
>
> Yep, Sergei's right. Both of our patches are dumb.
>
>
>> Ugh, looks like I'll have t submit the patch myself to stop this ugliness...
>>
>
> Is this what you had in mind?
>
Sure.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: petkovbb@gmail.com, Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Mark de Wever <koraq@xs4all.nl>,
Gadi Oxman <gadio@netvision.net.il>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IDE-TAPE NULL terminate strings.
Date: Tue, 23 Sep 2008 13:29:17 +0400 [thread overview]
Message-ID: <48D8B6ED.6020407@ru.mvista.com> (raw)
In-Reply-To: <20080923074845.GB5656@gollum.tnic>
Hello.
Borislav Petkov wrote:
>>> Only not sure whether the static is the best solution, the following
>>> patch also works, by zeroing the memory as you suggested.
>>>
>>> Signed-off-by: Mark de Wever <koraq@xs4all.nl>
>>>
>>> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
>>> index 1bce84b..c41f5b1 100644
>>> --- a/drivers/ide/ide-tape.c
>>> +++ b/drivers/ide/ide-tape.c
>>> @@ -2338,7 +2338,7 @@ static void idetape_get_inquiry_results(ide_drive_t *drive)
>>> {
>>> idetape_tape_t *tape = drive->driver_data;
>>> struct ide_atapi_pc pc;
>>> - char fw_rev[6], vendor_id[10], product_id[18];
>>> + char fw_rev[6] = {'\0'}, vendor_id[10] = {'\0'}, product_id[18] = {'\0'};
>>>
>>>
>> Do you realize how much *absolutely unnecessary* code will this bring
>> in? This is certainly worse than your initial patch (if it was correct).
>>
>
> Yep, Sergei's right. Both of our patches are dumb.
>
>
>> Ugh, looks like I'll have t submit the patch myself to stop this ugliness...
>>
>
> Is this what you had in mind?
>
Sure.
WBR, Sergei
next prev parent reply other threads:[~2008-09-23 9:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-21 18:51 [PATCH] IDE-TAPE NULL terminate strings Mark de Wever
2008-09-21 19:24 ` Sergei Shtylyov
2008-09-21 20:08 ` Sergei Shtylyov
2008-09-21 20:29 ` Mark de Wever
2008-09-21 22:12 ` Sergei Shtylyov
2008-09-22 13:16 ` Sergei Shtylyov
2008-09-22 13:56 ` Boris Petkov
2008-09-22 20:41 ` Mark de Wever
2008-09-22 21:08 ` Sergei Shtylyov
2008-09-23 7:48 ` Borislav Petkov
2008-09-23 9:29 ` Sergei Shtylyov [this message]
2008-09-23 9:29 ` Sergei Shtylyov
2008-09-23 13:40 ` Boris Petkov
2008-09-23 16:59 ` Mark de Wever
2008-09-23 16:59 ` Mark de Wever
2008-09-23 17:11 ` Boris Petkov
2008-09-23 21:20 ` IDE-TAPE regressions [was: [PATCH] IDE-TAPE NULL terminate strings.] Mark de Wever
2008-10-07 18:26 ` [patch][repost] ide-tape build fix Mark de Wever
2008-10-08 6:33 ` Borislav Petkov
2008-10-08 15:45 ` Mark de Wever
2008-10-08 15:45 ` Mark de Wever
2008-10-08 16:22 ` Boris Petkov
2008-10-08 18:37 ` Bartlomiej Zolnierkiewicz
2008-09-24 7:10 ` [PATCH] IDE-TAPE NULL terminate strings Borislav Petkov
2008-09-24 7:10 ` Borislav Petkov
2008-09-24 9:36 ` Sergei Shtylyov
2008-09-24 9:36 ` Sergei Shtylyov
2008-09-27 17:04 ` Bartlomiej Zolnierkiewicz
2008-09-23 16:14 ` Mark de Wever
2008-09-23 17:10 ` Sergei Shtylyov
2008-09-23 17:27 ` Mark de Wever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D8B6ED.6020407@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=gadio@netvision.net.il \
--cc=koraq@xs4all.nl \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.