From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] [RFC][PATCH] Factor out xnsynch_acquire/release
Date: Mon, 22 Sep 2008 20:41:43 +0200 [thread overview]
Message-ID: <48D7E6E7.9050302@domain.hid> (raw)
In-Reply-To: <48D75DE5.9020805@domain.hid>
Jan Kiszka wrote:
> Gilles Chanteperdrix wrote:
>> Jan Kiszka wrote:
>>> Gilles Chanteperdrix wrote:
>>>> Jan Kiszka wrote:
>>>>
>>>>> [1]http://thread.gmane.org/gmane.linux.real-time.xenomai.devel/5412/focus=5405
>>>>>
>>>> always-put-xnthread-base-into-registry.patch:
>>>> I understand the need, but I will cowardly let Philippe decide whether
>>>> he likes the implementation details.
>>>>
>>>> handle-base-xn_sys_current-1.patch:
>>>> In some places (pse51_mutex_timedlock_inner for instances) you use
>>>> XN_NO_HANDLE, in others (pse51_mutex_timedlock for instances) you use
>>>> NULL, are the two equivalents ? If yes, should not we always use the
>>>> same consistently ? Otherwise looks ok.
>>> I fail to find the NULL spots - which pse51_mutex_timedlock do you mean?
>> A few excerpts:
>
> Ah, you mean checking against non-zero - that can be changed of course.
> Updated patch below, hope I caught them all.
Ok. Looks good to me. Minus the bug in mutex_save_count, but this can be
changed later.
--
Gilles.
next prev parent reply other threads:[~2008-09-22 18:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 15:14 [Xenomai-core] [RFC][PATCH] Factor out xnsynch_acquire/release Jan Kiszka
2008-09-15 17:10 ` Jan Kiszka
2008-09-16 17:15 ` Philippe Gerum
2008-09-21 10:24 ` Jan Kiszka
2008-09-21 17:48 ` Gilles Chanteperdrix
2008-09-21 18:07 ` Jan Kiszka
2008-09-21 19:03 ` Gilles Chanteperdrix
2008-09-22 8:09 ` Jan Kiszka
2008-09-22 8:18 ` Gilles Chanteperdrix
2008-09-22 8:57 ` Jan Kiszka
2008-09-22 18:41 ` Gilles Chanteperdrix [this message]
2008-09-23 8:44 ` Jan Kiszka
2008-09-23 8:45 ` Gilles Chanteperdrix
2008-09-23 9:01 ` Jan Kiszka
2008-09-22 8:19 ` Philippe Gerum
2008-09-23 14:59 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D7E6E7.9050302@domain.hid \
--to=gilles.chanteperdrix@xenomai.org \
--cc=jan.kiszka@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.