pkgconfig.bbclass changes

pkgconfig.bbclass changes

[Koen Kooi]

Hi,

Henning fixed up pkgconfig.bbclass (which should die, since 
autotools.bbclass does a much better job), but I think this:

-       for pc in `find ${S} -name '*.pc' -type f | grep -v -- 
'-uninstalled.pc$'`; do
+       for pc in `find ${D} -name '*.pc' -type f | grep -v -- 
'-uninstalled.pc$'`; do

breaks -native recipes.

regards,

Koen

Re: pkgconfig.bbclass changes

[Henning Heinold]

On Tue, Sep 23, 2008 at 01:54:23PM +0200, Koen Kooi wrote:
> Hi,
> 
> Henning fixed up pkgconfig.bbclass (which should die, since 
> autotools.bbclass does a much better job), but I think this:
> 
> -       for pc in `find ${S} -name '*.pc' -type f | grep -v -- 
> '-uninstalled.pc$'`; do
> +       for pc in `find ${D} -name '*.pc' -type f | grep -v -- 
> '-uninstalled.pc$'`; do
> 
> breaks -native recipes.
> 
> regards,
> 
> Koen

Hi,

sorry you are right. This indeed breaks native packages I didnt
thought of it, while fixing the pc file of xine. 

I think we can not let die pkgconfig.bbclass, because not all features are
in autotools.class and there are cases where staging or install
do not depend on the autotools install routines.

Bye Henning

Re: pkgconfig.bbclass changes

[Koen Kooi]

Henning Heinold wrote:
> On Tue, Sep 23, 2008 at 01:54:23PM +0200, Koen Kooi wrote:
>> Hi,
>>
>> Henning fixed up pkgconfig.bbclass (which should die, since
>> autotools.bbclass does a much better job), but I think this:
>>
>> -       for pc in `find ${S} -name '*.pc' -type f | grep -v --
>> '-uninstalled.pc$'`; do
>> +       for pc in `find ${D} -name '*.pc' -type f | grep -v --
>> '-uninstalled.pc$'`; do
>>
>> breaks -native recipes.
>>
>> regards,
>>
>> Koen
>
> Hi,
>
> sorry you are right. This indeed breaks native packages I didnt
> thought of it, while fixing the pc file of xine.

I've been there myself: fixing bugs and then hearing people about 
-native being broken.

> I think we can not let die pkgconfig.bbclass, because not all features are
> in autotools.class and there are cases where staging or install
> do not depend on the autotools install routines.

You are completely right about that, but we should move over autotools 
based recipes to the autotools code and only use pkgconfig.bbclass for 
non-autotooled recipes.

regards,

Koen

Re: pkgconfig.bbclass changes

[Philip Balister]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

Henning Heinold wrote:
> On Tue, Sep 23, 2008 at 01:54:23PM +0200, Koen Kooi wrote:
>> Hi,
>>
>> Henning fixed up pkgconfig.bbclass (which should die, since 
>> autotools.bbclass does a much better job), but I think this:
>>
>> -       for pc in `find ${S} -name '*.pc' -type f | grep -v -- 
>> '-uninstalled.pc$'`; do
>> +       for pc in `find ${D} -name '*.pc' -type f | grep -v -- 
>> '-uninstalled.pc$'`; do
>>
>> breaks -native recipes.
>>
>> regards,
>>
>> Koen
> 
> Hi,
> 
> sorry you are right. This indeed breaks native packages I didnt
> thought of it, while fixing the pc file of xine. 

Does anyone know what the proper fix is? .dev does not build at the moment.

Philip



> I think we can not let die pkgconfig.bbclass, because not all features are
> in autotools.class and there are cases where staging or install
> do not depend on the autotools install routines.
> 
> Bye Henning
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> 

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3303 bytes --]

Re: pkgconfig.bbclass changes

[Koen Kooi]

Philip Balister wrote:
> Henning Heinold wrote:
>> On Tue, Sep 23, 2008 at 01:54:23PM +0200, Koen Kooi wrote:
>>> Hi,
>>>
>>> Henning fixed up pkgconfig.bbclass (which should die, since
>>> autotools.bbclass does a much better job), but I think this:
>>>
>>> - for pc in `find ${S} -name '*.pc' -type f | grep -v --
>>> '-uninstalled.pc$'`; do
>>> + for pc in `find ${D} -name '*.pc' -type f | grep -v --
>>> '-uninstalled.pc$'`; do
>>>
>>> breaks -native recipes.
>>>
>>> regards,
>>>
>>> Koen
>>
>> Hi,
>>
>> sorry you are right. This indeed breaks native packages I didnt
>> thought of it, while fixing the pc file of xine.
>
> Does anyone know what the proper fix is? .dev does not build at the moment.

revert the above hunk, bump PR on affected packages.

regards,

Koen


>
> Philip
>
>
>
>> I think we can not let die pkgconfig.bbclass, because not all features
>> are
>> in autotools.class and there are cases where staging or install
>> do not depend on the autotools install routines.
>>
>> Bye Henning
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel