From: Avi Kivity <avi@redhat.com>
To: "Han, Weidong" <weidong.han@intel.com>
Cc: kvm@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"Kay, Allen M" <allen.m.kay@intel.com>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Amit Shah <amit.shah@redhat.com>,
"Yang, Sheng" <sheng.yang@intel.com>
Subject: Re: [PATCH] VT-d: remove useless header inclusion
Date: Wed, 24 Sep 2008 12:13:48 +0300 [thread overview]
Message-ID: <48DA04CC.7020207@redhat.com> (raw)
In-Reply-To: <0122C7C995D32147B66BF4F440D3016301C4A0B2@pdsmsx415.ccr.corp.intel.com>
Han, Weidong wrote:
> Avi Kivity wrote:
>
>> Han, Weidong wrote:
>>
>>> Currently "#include <linux/intel-iommu.h>" is not needed in
>>> virt/kvm/kvm_main.c. What's more, this inclusion may result in
>>> compilation error in other architecture.
>>>
>>>
>>>
>> Applied, but please also fix intel-iommu.h to compile on all archs.
>>
>
> Avi,
>
> Current intel-iommu.h should be compiled on all archs. On linux-next,
> they moved __iommu_clflush_cache() definition to intel-iomm.h, which
> results in it cannot pass compilation on some archs, such as IA64.
>
Well, it still wants fixing, even if it is in linux-next only.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-09-24 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 5:45 [PATCH] VT-d: remove useless header inclusion Han, Weidong
2008-09-24 8:55 ` Avi Kivity
2008-09-24 9:09 ` Han, Weidong
2008-09-24 9:13 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DA04CC.7020207@redhat.com \
--to=avi@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=allen.m.kay@intel.com \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sheng.yang@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=weidong.han@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.