From: "Jan Beulich" <jbeulich@novell.com>
To: Haitao Shan <haitao.shan@intel.com>
Cc: Anish Bhatt <anish@cc.gatech.edu>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <keir.fraser@eu.citrix.com>
Subject: RE: MSI causing softpanics in guest
Date: Wed, 24 Sep 2008 11:59:43 +0100 [thread overview]
Message-ID: <48DA39BF.76E4.0078.0@novell.com> (raw)
In-Reply-To: <F6473715D25C9E46A5515027E5482F100887BDB2C6@pdsmsx502.ccr.corp.intel.com>
>--- a/drivers/pci/msi-xen.c Mon Sep 22 16:08:10 2008 +0100
>+++ b/drivers/pci/msi-xen.c Wed Sep 24 01:45:16 2008 +0800
>@@ -158,7 +158,11 @@ static int msi_unmap_pirq(struct pci_dev
> int rc;
>
> unmap.domid = msi_get_dev_owner(dev);
>- unmap.pirq = evtchn_get_xen_pirq(pirq);
>+ /* See comments in msi_map_pirq_to_vector, input parameter pirq
>+ * mean irq number only if the device belongs to dom0 itself.
>+ */
>+ if (unmap.domid == DOMID_SELF)
>+ unmap.pirq = evtchn_get_xen_pirq(pirq);
This seems to leave unmap.pirq uninitialized in the !DOMID_SELF case.
Otherwise, seems a reasonable alternative to doing it in pcifront/pciback.
Jan
next prev parent reply other threads:[~2008-09-24 10:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 19:53 MSI causing softpanics in guest Anish Bhatt
2008-09-20 8:15 ` Keir Fraser
[not found] ` <48D52FE7.7050207@gatech.edu>
2008-09-21 14:23 ` Shan, Haitao
[not found] ` <48D6968A.4050502@gatech.edu>
2008-09-22 1:41 ` Shan, Haitao
2008-09-22 8:12 ` Jan Beulich
[not found] ` <48D878CB.6060404@gatech.edu>
2008-09-23 7:23 ` Jan Beulich
2008-09-23 7:50 ` Shan, Haitao
2008-09-23 8:14 ` Keir Fraser
2008-09-23 8:26 ` Shan, Haitao
2008-09-23 8:30 ` Keir Fraser
2008-09-23 8:33 ` Shan, Haitao
2008-09-24 0:07 ` Anish Bhatt
2008-09-24 1:24 ` Shan, Haitao
2008-09-24 6:04 ` Keir Fraser
2008-09-24 6:28 ` Shan, Haitao
2008-09-24 9:38 ` Shan, Haitao
2008-09-24 10:30 ` Keir Fraser
2008-09-24 10:59 ` Jan Beulich [this message]
2008-09-27 2:41 ` Anish Bhatt
2008-09-27 3:33 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DA39BF.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=anish@cc.gatech.edu \
--cc=haitao.shan@intel.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.