From: Jeff Garzik <jeff@garzik.org>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
mingo@elte.hu, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
akpm@linux-foundation.org
Subject: Re: [NET-NEXT PATCH] e1000: remove unused Kconfig option for disabling packet split
Date: Wed, 24 Sep 2008 22:14:37 -0400 [thread overview]
Message-ID: <48DAF40D.3040005@garzik.org> (raw)
In-Reply-To: <Pine.WNT.4.63.0809161258170.3244@jbrandeb-desk.amr.corp.intel.com>
Brandeburg, Jesse wrote:
> On Wed, 3 Sep 2008, Jeff Garzik wrote:
>>> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>>>
>>> Since the e1000/e1000e split, no hardware supported by e1000
>>> supports packet split, just remove the Kconfig option and associated
>>> code from arch/* and the driver.
>>>
>>> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
>>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>>> ---
>>>
>>> arch/arm/configs/iop13xx_defconfig | 1
>>> arch/arm/configs/iop32x_defconfig | 1
>> ACK, except for the defconfig changes. arch maintainers usually prefer to do
>> that themselves.
>>
>> We'd be continually patch defconfig files, if we did so every time it was
>> likely one would be updated by a Kconfig patch.
>
> Here is an updated patch without the defconfig changes
>
> == cut here ==
>
> e1000: remove Kconfig option for packet split and e1000 related code
>
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> Since the e1000/e1000e split, no hardware supported by e1000
> supports packet split, just remove the Kconfig option and associated
> code from the driver.
>
> reposted without the defconfig changes, should apply to net-next
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> drivers/net/Kconfig | 9 -
> drivers/net/e1000/e1000.h | 17 --
> drivers/net/e1000/e1000_main.c | 416 +---------------------------------------
> 3 files changed, 9 insertions(+), 433 deletions(-)
applied
prev parent reply other threads:[~2008-09-25 2:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 8:19 [NET-NEXT PATCH] e1000: remove unused Kconfig option for disabling packet split Jeff Kirsher
2008-09-03 13:59 ` Jeff Garzik
2008-09-16 20:01 ` Brandeburg, Jesse
2008-09-25 2:14 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DAF40D.3040005@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.