All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] skge: Fix skge_set_ring_param() losing error return
@ 2008-09-26  8:32 Wang Chen
  0 siblings, 0 replies; only message in thread
From: Wang Chen @ 2008-09-26  8:32 UTC (permalink / raw)
  To: jeff; +Cc: Stephen Hemminger, NETDEV

From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Fri, 26 Sep 2008 16:20:32 +0800
Subject: [PATCH] skge: Fix skge_set_ring_param() losing error return

The error return is useful to caller, driver shouldn't miss it.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
---
 drivers/net/skge.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index 2e26dce..4c333a1 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -494,7 +494,7 @@ static int skge_set_ring_param(struct net_device *dev,
 			       struct ethtool_ringparam *p)
 {
 	struct skge_port *skge = netdev_priv(dev);
-	int err;
+	int err = 0;
 
 	if (p->rx_pending == 0 || p->rx_pending > MAX_RX_RING_SIZE ||
 	    p->tx_pending < TX_LOW_WATER || p->tx_pending > MAX_TX_RING_SIZE)
@@ -510,7 +510,7 @@ static int skge_set_ring_param(struct net_device *dev,
 			dev_close(dev);
 	}
 
-	return 0;
+	return err;
 }
 
 static u32 skge_get_msglevel(struct net_device *netdev)
-- 
1.5.5.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-09-26  8:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-26  8:32 [PATCH] skge: Fix skge_set_ring_param() losing error return Wang Chen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.