From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [patch] stop passing in global variable as argument to cmos_init()
Date: Sat, 27 Sep 2008 10:51:31 +0000 [thread overview]
Message-ID: <48DE1033.5020704@redhat.com> (raw)
In-Reply-To: <48DCDD8E.4070409@sgi.com>
Jes Sorensen wrote:
> Hi,
>
> Looking through the ia64 code I came across this little gem.
>
> At some point someone added a new argument to hw/pc.c:cmos_init() named
> 'smp_cpus', and then passed in the global variable 'smp_cpus' as the
> argument. This propagated through to the ia64 code as well.
>
> I checked, this isn't present in the upstream QEMU code, so lets kill
> it in the KVM branch. One small step to get closer to upstream :-)
>
Applied, thanks (though personally I prefer not depending on global
variables and their initialization order, etc.)
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Jes Sorensen <jes@sgi.com>
Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: Re: [patch] stop passing in global variable as argument to cmos_init()
Date: Sat, 27 Sep 2008 13:51:31 +0300 [thread overview]
Message-ID: <48DE1033.5020704@redhat.com> (raw)
In-Reply-To: <48DCDD8E.4070409@sgi.com>
Jes Sorensen wrote:
> Hi,
>
> Looking through the ia64 code I came across this little gem.
>
> At some point someone added a new argument to hw/pc.c:cmos_init() named
> 'smp_cpus', and then passed in the global variable 'smp_cpus' as the
> argument. This propagated through to the ia64 code as well.
>
> I checked, this isn't present in the upstream QEMU code, so lets kill
> it in the KVM branch. One small step to get closer to upstream :-)
>
Applied, thanks (though personally I prefer not depending on global
variables and their initialization order, etc.)
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-09-27 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 13:03 [patch] stop passing in global variable as argument to cmos_init() Jes Sorensen
2008-09-26 13:03 ` Jes Sorensen
2008-09-27 10:51 ` Avi Kivity [this message]
2008-09-27 10:51 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DE1033.5020704@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.