From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"xemul@openvz.org" <xemul@openvz.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>
Subject: Re: [PATCH 1/4] memcg: account swap cache under lock
Date: Tue, 30 Sep 2008 13:35:41 +0530 [thread overview]
Message-ID: <48E1DDD5.9040304@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080929192123.5ce60c24.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> While page-cache's charge/uncharge is done under page_lock(), swap-cache
> isn't. (anonymous page is charged when it's newly allocated.)
>
> This patch moves do_swap_page()'s charge() call under lock.
> I don't see any bad problem *now* but this fix will be good for future
> for avoiding unneccesary racy state.
>
>
> Changelog: (v5) -> (v6)
> - mark_page_accessed() is moved before lock_page().
> - fixed missing unlock_page()
> (no changes in previous version)
Looks good to me
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Balbir
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"xemul@openvz.org" <xemul@openvz.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>
Subject: Re: [PATCH 1/4] memcg: account swap cache under lock
Date: Tue, 30 Sep 2008 13:35:41 +0530 [thread overview]
Message-ID: <48E1DDD5.9040304@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080929192123.5ce60c24.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> While page-cache's charge/uncharge is done under page_lock(), swap-cache
> isn't. (anonymous page is charged when it's newly allocated.)
>
> This patch moves do_swap_page()'s charge() call under lock.
> I don't see any bad problem *now* but this fix will be good for future
> for avoiding unneccesary racy state.
>
>
> Changelog: (v5) -> (v6)
> - mark_page_accessed() is moved before lock_page().
> - fixed missing unlock_page()
> (no changes in previous version)
Looks good to me
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-09-30 8:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 10:19 [PATCH 0/4] memcg: ready-to-go series (was memcg update v6) KAMEZAWA Hiroyuki
2008-09-29 10:19 ` KAMEZAWA Hiroyuki
2008-09-29 10:21 ` [PATCH 1/4] memcg: account swap cache under lock KAMEZAWA Hiroyuki
2008-09-29 10:21 ` KAMEZAWA Hiroyuki
2008-09-29 11:33 ` Daisuke Nishimura
2008-09-29 11:33 ` Daisuke Nishimura
2008-09-30 8:05 ` Balbir Singh [this message]
2008-09-30 8:05 ` Balbir Singh
2008-09-29 10:22 ` [PATCH 2/4] memcg: set page->mapping NULL before uncharge KAMEZAWA Hiroyuki
2008-09-29 10:22 ` KAMEZAWA Hiroyuki
2008-09-29 11:39 ` Daisuke Nishimura
2008-09-29 11:39 ` Daisuke Nishimura
2008-10-01 3:50 ` Balbir Singh
2008-10-01 3:50 ` Balbir Singh
2008-09-29 10:23 ` [PATCH 3/4] memcg: avoid account not-on-LRU pages KAMEZAWA Hiroyuki
2008-09-29 10:23 ` KAMEZAWA Hiroyuki
2008-09-29 11:19 ` Daisuke Nishimura
2008-09-29 11:19 ` Daisuke Nishimura
2008-09-29 11:59 ` kamezawa.hiroyu
2008-09-29 11:59 ` kamezawa.hiroyu
2008-09-30 1:17 ` [PATCH/stylefix " KAMEZAWA Hiroyuki
2008-09-30 1:17 ` KAMEZAWA Hiroyuki
2008-10-01 3:49 ` Balbir Singh
2008-10-01 3:49 ` Balbir Singh
2008-10-01 4:50 ` KAMEZAWA Hiroyuki
2008-10-01 4:50 ` KAMEZAWA Hiroyuki
2008-09-30 8:14 ` [PATCH " Balbir Singh
2008-09-30 8:14 ` Balbir Singh
2008-09-29 10:24 ` [PATCH 4/4] memcg: optimze cpustat KAMEZAWA Hiroyuki
2008-09-29 10:24 ` KAMEZAWA Hiroyuki
2008-09-29 11:44 ` Daisuke Nishimura
2008-09-29 11:44 ` Daisuke Nishimura
2008-10-06 17:15 ` [PATCH 0/4] memcg: ready-to-go series (was memcg update v6) Balbir Singh
2008-10-06 17:15 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E1DDD5.9040304@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.