All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, jeremy@goop.org, ebiederm@xmission.com,
	travis@sgi.com, herbert@gondor.apana.org.au, xemul@openvz.org
Subject: Re: [patch 2/3] cpu alloc: Remove slub fields
Date: Wed, 01 Oct 2008 20:53:08 +0300	[thread overview]
Message-ID: <48E3B904.7020206@cs.helsinki.fi> (raw)
In-Reply-To: <20080919203724.240858174@quilx.com>

Hi Christoph,

Christoph Lameter wrote:
> @@ -2196,8 +2163,11 @@
>  	if (!init_kmem_cache_nodes(s, gfpflags & ~SLUB_DMA))
>  		goto error;
>  
> -	if (alloc_kmem_cache_cpus(s, gfpflags & ~SLUB_DMA))
> +	s->cpu_slab = CPU_ALLOC(struct kmem_cache_cpu,
> +				(flags & ~SLUB_DMA) | __GFP_ZERO);
> +	if (!s->cpu_slab)
>  		return 1;

This should be s->cpu_slab, no?

> +
>  	free_kmem_cache_nodes(s);
>  error:
>  	if (flags & SLAB_PANIC)


WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, jeremy@goop.org, ebiederm@xmission.com,
	travis@sgi.com, herbert@gondor.apana.org.au, xemul@openvz.org
Subject: Re: [patch 2/3] cpu alloc: Remove slub fields
Date: Wed, 01 Oct 2008 20:53:08 +0300	[thread overview]
Message-ID: <48E3B904.7020206@cs.helsinki.fi> (raw)
In-Reply-To: <20080919203724.240858174@quilx.com>

Hi Christoph,

Christoph Lameter wrote:
> @@ -2196,8 +2163,11 @@
>  	if (!init_kmem_cache_nodes(s, gfpflags & ~SLUB_DMA))
>  		goto error;
>  
> -	if (alloc_kmem_cache_cpus(s, gfpflags & ~SLUB_DMA))
> +	s->cpu_slab = CPU_ALLOC(struct kmem_cache_cpu,
> +				(flags & ~SLUB_DMA) | __GFP_ZERO);
> +	if (!s->cpu_slab)
>  		return 1;

This should be s->cpu_slab, no?

> +
>  	free_kmem_cache_nodes(s);
>  error:
>  	if (flags & SLAB_PANIC)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-10-01 17:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-19 20:37 [patch 0/3] Cpu alloc slub support: Replace percpu allocator in slub.c Christoph Lameter
2008-09-19 20:37 ` Christoph Lameter
2008-09-19 20:37 ` [patch 1/3] cpu alloc: Use in slub Christoph Lameter
2008-09-19 20:37   ` Christoph Lameter
2008-09-19 20:37 ` [patch 2/3] cpu alloc: Remove slub fields Christoph Lameter
2008-09-19 20:37   ` Christoph Lameter
2008-10-01 17:53   ` Pekka Enberg [this message]
2008-10-01 17:53     ` Pekka Enberg
2008-10-02 16:21     ` Christoph Lameter
2008-10-02 16:21       ` Christoph Lameter
2008-09-19 20:37 ` [patch 3/3] Increase default reserve percpu area Christoph Lameter
2008-09-19 20:37   ` Christoph Lameter
2008-09-19 22:02   ` Pekka Enberg
2008-09-19 22:02     ` Pekka Enberg
2008-09-19 22:07     ` Pekka Enberg
2008-09-19 22:07       ` Pekka Enberg
2008-09-19 21:57 ` [patch 0/3] Cpu alloc slub support: Replace percpu allocator in slub.c Pekka Enberg
2008-09-19 21:57   ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E3B904.7020206@cs.helsinki.fi \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=travis@sgi.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.