From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH 0/8] Patchset to enable vt-d support for kvm/ia64.
Date: Thu, 02 Oct 2008 15:32:13 +0000 [thread overview]
Message-ID: <48E4E97D.4080701@redhat.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01A53DEF@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> +
> +/* This should be called with the kvm->lock mutex held */
> +void kvm_set_irq(struct kvm *kvm, int irq, int level)
> +{
> + /* Not possible to detect if the guest uses the PIC or the
> + * IOAPIC. So set the bit in both. The guest will ignore
> + * writes to the unused one.
> + */
> + kvm_ioapic_set_irq(kvm->arch.vioapic, irq, level);
> +#ifdef X86
> + kvm_pic_set_irq(pic_irqchip(kvm), irq, level);
> +#endif
> +}
>
Will non-x86, non-ia64 archs survive this?
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: Re: [PATCH 0/8] Patchset to enable vt-d support for kvm/ia64.
Date: Thu, 02 Oct 2008 18:32:13 +0300 [thread overview]
Message-ID: <48E4E97D.4080701@redhat.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01A54162@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> +
> +/* This should be called with the kvm->lock mutex held */
> +void kvm_set_irq(struct kvm *kvm, int irq, int level)
> +{
> + /* Not possible to detect if the guest uses the PIC or the
> + * IOAPIC. So set the bit in both. The guest will ignore
> + * writes to the unused one.
> + */
> + kvm_ioapic_set_irq(kvm->arch.vioapic, irq, level);
> +#ifdef X86
> + kvm_pic_set_irq(pic_irqchip(kvm), irq, level);
> +#endif
> +}
>
Will non-x86, non-ia64 archs survive this?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-10-02 15:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 5:25 [PATCH 0/8] Patchset to enable vt-d support for kvm/ia64 Zhang, Xiantao
2008-09-29 5:25 ` Zhang, Xiantao
2008-10-02 13:06 ` Avi Kivity
2008-10-02 13:06 ` Avi Kivity
2008-10-02 15:14 ` Zhang, Xiantao
2008-10-02 15:14 ` Zhang, Xiantao
2008-10-02 15:32 ` Avi Kivity [this message]
2008-10-02 15:32 ` Avi Kivity
2008-10-03 2:13 ` Zhang, Xiantao
2008-10-03 2:13 ` Zhang, Xiantao
2008-10-07 9:47 ` Avi Kivity
2008-10-07 9:47 ` Avi Kivity
2008-10-07 9:50 ` Zhang, Xiantao
2008-10-07 9:50 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E4E97D.4080701@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.