[lm-sensors] Looking for IT8720 datasheet.

[lm-sensors] Looking for IT8720 datasheet.

[Jean-Marc Spaggiari]

Hi,

Does any one have the IT8720 datasheet? In ticket #2343,
http://www.lm-sensors.org/ticket/2343 sound like the datasheet is now
available ("We have a datasheet now.").

Is there a way to get this datasheet? I'm building a patch for it87.c.
It's working pretty fine with my motherboard, but I would like to
double check with the datasheet before submiting the patch to LKML.

Thanks,

Jean-Marc

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Jean Delvare]

Hi Jean-Marc,

On Thu, 2 Oct 2008 11:25:27 -0400, Jean-Marc Spaggiari wrote:
> Does any one have the IT8720 datasheet? In ticket #2343,
> http://www.lm-sensors.org/ticket/2343 sound like the datasheet is now
> available ("We have a datasheet now.").

We have it but it's not public yet, so we can't redistribute it.

> Is there a way to get this datasheet? I'm building a patch for it87.c.
> It's working pretty fine with my motherboard, but I would like to
> double check with the datasheet before submiting the patch to LKML.

Please get in touch with Frank Myhr (Cc'd), who is supposedly working
on this already. Please do not duplicate the work here. Ideally, if
Frank is done with the code, you could give it a public review, and
then the code can be merged.

Patches should be submitted to the lm-sensors list rather than LKML.
While we still do not have a hwmon subsystem maintainer, you are more
likely to find reviewers and testers on the lm-sensors list than on
LKML.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Jean-Marc Spaggiari]

Hi Jean,

Thanks for your reply.


Hi Frank,

Did you get a chance to work on IT8720? I have modify the
sensors-detect script to return it87, and also modify it87.c to handle
the IT8720 as any other IT87 chipset, and it seems to work pretty
fine. It's fine for the FANs and the temp, but I'm not 100% sur for
the voltage.

in0:         +0.00 V  (min =  +0.00 V, max =  +4.08 V)   ALARM
in1:         +3.02 V  (min =  +0.00 V, max =  +4.08 V)
in2:         +3.42 V  (min =  +0.00 V, max =  +4.08 V)
in3:         +3.01 V  (min =  +0.00 V, max =  +4.08 V)
in4:         +1.22 V  (min =  +0.00 V, max =  +4.08 V)
in5:         +2.62 V  (min =  +0.00 V, max =  +4.08 V)
in6:         +2.59 V  (min =  +0.00 V, max =  +4.08 V)
in7:         +3.01 V  (min =  +0.00 V, max =  +4.08 V)
in8:         +3.38 V


I didn't get the +12 or -5 or others. I was able to get it one time,
and no more. Any idea?

Thanks,

JM

2008/10/2 Jean Delvare <khali@linux-fr.org>:
> Hi Jean-Marc,
>
> On Thu, 2 Oct 2008 11:25:27 -0400, Jean-Marc Spaggiari wrote:
>> Does any one have the IT8720 datasheet? In ticket #2343,
>> http://www.lm-sensors.org/ticket/2343 sound like the datasheet is now
>> available ("We have a datasheet now.").
>
> We have it but it's not public yet, so we can't redistribute it.
>
>> Is there a way to get this datasheet? I'm building a patch for it87.c.
>> It's working pretty fine with my motherboard, but I would like to
>> double check with the datasheet before submiting the patch to LKML.
>
> Please get in touch with Frank Myhr (Cc'd), who is supposedly working
> on this already. Please do not duplicate the work here. Ideally, if
> Frank is done with the code, you could give it a public review, and
> then the code can be merged.
>
> Patches should be submitted to the lm-sensors list rather than LKML.
> While we still do not have a hwmon subsystem maintainer, you are more
> likely to find reviewers and testers on the lm-sensors list than on
> LKML.
>
> --
> Jean Delvare
>

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Jean Delvare]

On Thu, 2 Oct 2008 12:28:40 -0400, Jean-Marc Spaggiari wrote:
> Did you get a chance to work on IT8720? I have modify the
> sensors-detect script to return it87, and also modify it87.c to handle
> the IT8720 as any other IT87 chipset, and it seems to work pretty
> fine. It's fine for the FANs and the temp, but I'm not 100% sur for
> the voltage.
> 
> in0:         +0.00 V  (min =  +0.00 V, max =  +4.08 V)   ALARM
> in1:         +3.02 V  (min =  +0.00 V, max =  +4.08 V)
> in2:         +3.42 V  (min =  +0.00 V, max =  +4.08 V)
> in3:         +3.01 V  (min =  +0.00 V, max =  +4.08 V)
> in4:         +1.22 V  (min =  +0.00 V, max =  +4.08 V)
> in5:         +2.62 V  (min =  +0.00 V, max =  +4.08 V)
> in6:         +2.59 V  (min =  +0.00 V, max =  +4.08 V)
> in7:         +3.01 V  (min =  +0.00 V, max =  +4.08 V)
> in8:         +3.38 V
> 
> 
> I didn't get the +12 or -5 or others. I was able to get it one time,
> and no more. Any idea?

This is expected. The IT87xxF use a 4V DAC, so you can only measure
voltage values up to 4V directly. For +5V, +12V and negative voltages,
there are scaling resistors on the motherboard. So you need proper
sensors.conf statements. You can try with the default settings for the
IT87xxF chips (see the default sensors.conf file) but your motherboard
may or may not follow these. So it can take some work to get things
right. Best is to compare with what the BIOS displays.

The typical way is to scale voltages so that their nominal value at the
chip's pin is 3V. So, looking at the above, it is likely that in1, in3,
and in7 are monitoring voltages above 4V. in7 is usually 5VSB. in2 is
probably +3.3V and in8 is most certainly Vbat.

As for negative voltage, check your BIOS, but you probably do not have
any. Most recent motherboards no longer bother monitoring them because
they are almost unused.

Strange thing is that in0 is 0V... on most boards, in0 is Vcore.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Frank Myhr]

Hi Jean-Marc,

That's great that you've modified it87.c to handle your IT8720. Why
don't you go ahead and post your patch to the list, I'll be happy to
have a look at it. My first priority is adding automatic mode support
for the 8718. I'm adding auto mode support for the 8720 and other chips
at the same time. But I'm still not ready to post that work yet. Anyway,
as far as on/off and software pwm modes go, the 8720 is almost exactly
the same as the 8718*, so you can do a simple search through the code
for conditionals on the 8718 and add the 8720 to them. (Sounds like
you've already done that.)

I have nothing to add to Jean's excellent answer regarding the voltage
inputs on it87. And I don't know what's going on with in0 on your board
either.

-Frank

* The one slight difference I'm aware of is that the 8720 uses ec
register 0x0b bits to control pwm4 and pwm5 in software pwm mode (since
it has 5 fans but only 3 pwm channels):

bits	RW  def notes
3-2	RW  11b	pwm5 same as:
		00b	pwm1
		01b	pwm2
		10b	pwm3
		11b	none
1-0	RW  11b	pwm4 same as pwm[1|2|3], codes as above

The 8718 also has 5 fans and only 3 pwm channels, but does not allow
choosing pwm4 and pwm5 control as above.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Jean-Marc Spaggiari]

Hi,

thanks all for all your detailed answers. Very useful. I got it
regarding the voltage.

Here is the patch I did for it87c. As you said, I simply searched for
IT8718 and add IT8720 to do the same.

I looked into my BIOS and here is what I have:
vCore = 1,33
3,3 = 3,4
5 = 5,02
12 = 12,09

Since I have identified the chipset from my mother board, can you let
me know wich pin are the "in" so I can mesure the resistors and
provide the values? You might found that (the pin#) in the datasheet I
hope.

Regarding pwm4 and pwm5, I'm not really sure how to do so, and I seen
that some fans info was missing. So I will try to figure how to use it
since I have 3 fans and only 2 are displayed.

fan1:       3013 RPM  (min =    0 RPM, div = 2)
fan2:          0 RPM  (min =    0 RPM, div = 2)
fan3:       5973 RPM  (min =    0 RPM, div = 2)

Last point, temperatures are slightly different from it8720 and k8temp.

temp1:       +41.0 °C  (low  =  -1.0 °C, high = +127.0 °C)  sensor = transistor
temp2:       +34.0 °C  (low  =  -1.0 °C, high =  -3.0 °C)  sensor = transistor
temp3:       +22.0 °C  (low  =  -5.0 °C, high = +127.0 °C)  sensor = transistor

k8temp-pci-00c3
Adapter: PCI adapter
Core0 Temp:  +43.0 °C
Core1 Temp:  +37.0 °C

Has it87 only the motherboard temp? In that case, why there is 3? I
will receive a 4-core this afternoon so I will be able to do some
other tests.

I will keep you posted if I'm able to do something for pwm4 and pwm5.

Regard,

Jean-Marc


--- linux-2.6.27-rc8/drivers/hwmon/it87.c.orig  2008-10-02
09:04:44.000000000 -0400
+++ linux-2.6.27-rc8/drivers/hwmon/it87.c       2008-10-03
09:01:10.000000000 -0400
@@ -14,6 +14,7 @@
               IT8712F  Super I/O chip w/LPC interface
               IT8716F  Super I/O chip w/LPC interface
               IT8718F  Super I/O chip w/LPC interface
+             IT8720F  Super I/O chip w/LPC interface
               IT8726F  Super I/O chip w/LPC interface
               Sis950   A clone of the IT8705F

@@ -50,7 +51,7 @@

 #define DRVNAME "it87"

-enum chips { it87, it8712, it8716, it8718 };
+enum chips { it87, it8712, it8716, it8718, it8720 };

 static unsigned short force_id;
 module_param(force_id, ushort, 0);
@@ -111,6 +112,7 @@ superio_exit(void)
 #define IT8705F_DEVID 0x8705
 #define IT8716F_DEVID 0x8716
 #define IT8718F_DEVID 0x8718
+#define IT8720F_DEVID 0x8720
 #define IT8726F_DEVID 0x8726
 #define IT87_ACT_REG  0x30
 #define IT87_BASE_REG 0x60
@@ -278,7 +280,8 @@ static inline int has_16bit_fans(const s
        return (data->type = it87 && data->revision >= 0x03)
            || (data->type = it8712 && data->revision >= 0x08)
            || data->type = it8716
-           || data->type = it8718;
+           || data->type = it8718
+           || data->type = it8720;
 }

 static int it87_probe(struct platform_device *pdev);
@@ -979,6 +982,9 @@ static int __init it87_find(unsigned sho
        case IT8726F_DEVID:
                sio_data->type = it8716;
                break;
+       case IT8720F_DEVID:
+               sio_data->type = it8720;
+               break;
        case IT8718F_DEVID:
                sio_data->type = it8718;
                break;
@@ -1012,7 +1018,7 @@ static int __init it87_find(unsigned sho
                int reg;

                superio_select(GPIO);
-               if (chip_type = it8718)
+               if (chip_type = it8718 || chip_type = it8720)
                        sio_data->vid_value = superio_inb(IT87_SIO_VID_REG);

                reg = superio_inb(IT87_SIO_PINX2_REG);
@@ -1040,6 +1046,7 @@ static int __devinit it87_probe(struct p
                "it8712",
                "it8716",
                "it8718",
+               "it8720",
        };

        res = platform_get_resource(pdev, IORESOURCE_IO, 0);
@@ -1190,7 +1197,7 @@ static int __devinit it87_probe(struct p
        }

        if (data->type = it8712 || data->type = it8716
-        || data->type = it8718) {
+        || data->type = it8718 || data->type = it8720) {
                data->vrm = vid_which_vrm();
                /* VID reading from Super-I/O config space if available */
                data->vid = sio_data->vid_value;
@@ -1571,7 +1578,7 @@ static void __exit sm_it87_exit(void)

 MODULE_AUTHOR("Chris Gauthron, "
              "Jean Delvare <khali@linux-fr.org>");
-MODULE_DESCRIPTION("IT8705F/8712F/8716F/8718F/8726F, SiS950 driver");
+MODULE_DESCRIPTION("IT8705F/8712F/8716F/8718F/8720F/8726F, SiS950 driver");
 module_param(update_vbat, bool, 0);
 MODULE_PARM_DESC(update_vbat, "Update vbat if set else return powerup value");
 module_param(fix_pwm_polarity, bool, 0);
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Frank Myhr]

Jean-Marc Spaggiari wrote:

> Since I have identified the chipset from my mother board, can you let
> me know wich pin are the "in" so I can mesure the resistors and
> provide the values? You might found that (the pin#) in the datasheet I
> hope.

8720 pins are numbered same as in 8718 datasheet. 8720 vin pins are as
follows:
vin0: 98
vin1: 97
vin2: 96
vin3: 95 (or ATX Power Good, depending on sw config regs)
vin4: 94 (or VLDT 1.2V analog input, depending on chip config)
vin5: 93 (or VDDA 2.5V analog input, depending on config)
vin6: 92 (or VDIMM 1.8V analog input, depending on config)
vin7: no pin, marked "internal" to chip (different from earlier it87's)
vin8 is vbatt (pin 69)


> Regarding pwm4 and pwm5, I'm not really sure how to do so, and I seen
> that some fans info was missing. So I will try to figure how to use it
> since I have 3 fans and only 2 are displayed.
> 
> fan1:       3013 RPM  (min =    0 RPM, div = 2)
> fan2:          0 RPM  (min =    0 RPM, div = 2)
> fan3:       5973 RPM  (min =    0 RPM, div = 2)

Simplest and probably best to just ignore/don't worry about pwm4 and
pwm5 for now. Letting the user select pwm4 and pwm5 control will require
new sysfs attributes, there is currently no standard for these.
Something like:
pwm[4|5]_control
	which could take values [1|2|3]
But I haven't yet successfully used pwm control on fans 4 and 5 on my
boards, not yet sure it's possible, so it's probably premature to
consider new sysfs interfaces for potentially useless features.


> Last point, temperatures are slightly different from it8720 and k8temp.
> 
> temp1:       +41.0 °C  (low  =  -1.0 °C, high = +127.0 °C)  sensor = transistor
> temp2:       +34.0 °C  (low  =  -1.0 °C, high =  -3.0 °C)  sensor = transistor
> temp3:       +22.0 °C  (low  =  -5.0 °C, high = +127.0 °C)  sensor = transistor
> 
> k8temp-pci-00c3
> Adapter: PCI adapter
> Core0 Temp:  +43.0 °C
> Core1 Temp:  +37.0 °C
> 
> Has it87 only the motherboard temp? In that case, why there is 3? I
> will receive a 4-core this afternoon so I will be able to do some
> other tests.

The temperatures reported by it87 depend on the sensor locations on your
motherboard. Since you're already tracing pins for vin's, here are temp
pins:
temp1: 90
temp2: 89
temp3: 88


> --- linux-2.6.27-rc8/drivers/hwmon/it87.c.orig  2008-10-02
> 09:04:44.000000000 -0400
> +++ linux-2.6.27-rc8/drivers/hwmon/it87.c       2008-10-03
> 09:01:10.000000000 -0400
> @@ -14,6 +14,7 @@
>                IT8712F  Super I/O chip w/LPC interface
>                IT8716F  Super I/O chip w/LPC interface
>                IT8718F  Super I/O chip w/LPC interface
> +             IT8720F  Super I/O chip w/LPC interface
>                IT8726F  Super I/O chip w/LPC interface
>                Sis950   A clone of the IT8705F
> 
> @@ -50,7 +51,7 @@
> 
>  #define DRVNAME "it87"
> 
> -enum chips { it87, it8712, it8716, it8718 };
> +enum chips { it87, it8712, it8716, it8718, it8720 };
> 
>  static unsigned short force_id;
>  module_param(force_id, ushort, 0);
> @@ -111,6 +112,7 @@ superio_exit(void)
>  #define IT8705F_DEVID 0x8705
>  #define IT8716F_DEVID 0x8716
>  #define IT8718F_DEVID 0x8718
> +#define IT8720F_DEVID 0x8720
>  #define IT8726F_DEVID 0x8726
>  #define IT87_ACT_REG  0x30
>  #define IT87_BASE_REG 0x60
> @@ -278,7 +280,8 @@ static inline int has_16bit_fans(const s
>         return (data->type = it87 && data->revision >= 0x03)
>             || (data->type = it8712 && data->revision >= 0x08)
>             || data->type = it8716
> -           || data->type = it8718;
> +           || data->type = it8718
> +           || data->type = it8720;
>  }
> 
>  static int it87_probe(struct platform_device *pdev);
> @@ -979,6 +982,9 @@ static int __init it87_find(unsigned sho
>         case IT8726F_DEVID:
>                 sio_data->type = it8716;
>                 break;
> +       case IT8720F_DEVID:
> +               sio_data->type = it8720;
> +               break;
>         case IT8718F_DEVID:
>                 sio_data->type = it8718;
>                 break;
> @@ -1012,7 +1018,7 @@ static int __init it87_find(unsigned sho
>                 int reg;
> 
>                 superio_select(GPIO);
> -               if (chip_type = it8718)
> +               if (chip_type = it8718 || chip_type = it8720)
>                         sio_data->vid_value = superio_inb(IT87_SIO_VID_REG);
> 
>                 reg = superio_inb(IT87_SIO_PINX2_REG);
> @@ -1040,6 +1046,7 @@ static int __devinit it87_probe(struct p
>                 "it8712",
>                 "it8716",
>                 "it8718",
> +               "it8720",
>         };
> 
>         res = platform_get_resource(pdev, IORESOURCE_IO, 0);
> @@ -1190,7 +1197,7 @@ static int __devinit it87_probe(struct p
>         }
> 
>         if (data->type = it8712 || data->type = it8716
> -        || data->type = it8718) {
> +        || data->type = it8718 || data->type = it8720) {
>                 data->vrm = vid_which_vrm();
>                 /* VID reading from Super-I/O config space if available */
>                 data->vid = sio_data->vid_value;
> @@ -1571,7 +1578,7 @@ static void __exit sm_it87_exit(void)
> 
>  MODULE_AUTHOR("Chris Gauthron, "
>               "Jean Delvare <khali@linux-fr.org>");
> -MODULE_DESCRIPTION("IT8705F/8712F/8716F/8718F/8726F, SiS950 driver");
> +MODULE_DESCRIPTION("IT8705F/8712F/8716F/8718F/8720F/8726F, SiS950 driver");
>  module_param(update_vbat, bool, 0);
>  MODULE_PARM_DESC(update_vbat, "Update vbat if set else return powerup value");
>  module_param(fix_pwm_polarity, bool, 0);

Changes look good to me.

-Frank

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Jean-Marc Spaggiari]

2008/10/3 Frank Myhr <fmyhr@fhmtech.com>:
> Jean-Marc Spaggiari wrote:
>
>> Since I have identified the chipset from my mother board, can you let
>> me know wich pin are the "in" so I can mesure the resistors and
>> provide the values? You might found that (the pin#) in the datasheet I
>> hope.
>
> 8720 pins are numbered same as in 8718 datasheet. 8720 vin pins are as
> follows:
> vin0: 98
> vin1: 97
> vin2: 96
> vin3: 95 (or ATX Power Good, depending on sw config regs)
> vin4: 94 (or VLDT 1.2V analog input, depending on chip config)
> vin5: 93 (or VDDA 2.5V analog input, depending on config)
> vin6: 92 (or VDIMM 1.8V analog input, depending on config)
> vin7: no pin, marked "internal" to chip (different from earlier it87's)
> vin8 is vbatt (pin 69)
>
>
>> Regarding pwm4 and pwm5, I'm not really sure how to do so, and I seen
>> that some fans info was missing. So I will try to figure how to use it
>> since I have 3 fans and only 2 are displayed.
>>
>> fan1:       3013 RPM  (min =    0 RPM, div = 2)
>> fan2:          0 RPM  (min =    0 RPM, div = 2)
>> fan3:       5973 RPM  (min =    0 RPM, div = 2)
>
> Simplest and probably best to just ignore/don't worry about pwm4 and
> pwm5 for now. Letting the user select pwm4 and pwm5 control will require
> new sysfs attributes, there is currently no standard for these.
> Something like:
> pwm[4|5]_control
>        which could take values [1|2|3]
> But I haven't yet successfully used pwm control on fans 4 and 5 on my
> boards, not yet sure it's possible, so it's probably premature to
> consider new sysfs interfaces for potentially useless features.
>
>
>> Last point, temperatures are slightly different from it8720 and k8temp.
>>
>> temp1:       +41.0 °C  (low  =  -1.0 °C, high = +127.0 °C)  sensor = transistor
>> temp2:       +34.0 °C  (low  =  -1.0 °C, high =  -3.0 °C)  sensor = transistor
>> temp3:       +22.0 °C  (low  =  -5.0 °C, high = +127.0 °C)  sensor = transistor
>>
>> k8temp-pci-00c3
>> Adapter: PCI adapter
>> Core0 Temp:  +43.0 °C
>> Core1 Temp:  +37.0 °C
>>
>> Has it87 only the motherboard temp? In that case, why there is 3? I
>> will receive a 4-core this afternoon so I will be able to do some
>> other tests.
>
> The temperatures reported by it87 depend on the sensor locations on your
> motherboard. Since you're already tracing pins for vin's, here are temp
> pins:
> temp1: 90
> temp2: 89
> temp3: 88
>
>
>> --- linux-2.6.27-rc8/drivers/hwmon/it87.c.orig  2008-10-02
>> 09:04:44.000000000 -0400
>> +++ linux-2.6.27-rc8/drivers/hwmon/it87.c       2008-10-03
>> 09:01:10.000000000 -0400
>> @@ -14,6 +14,7 @@
>>                IT8712F  Super I/O chip w/LPC interface
>>                IT8716F  Super I/O chip w/LPC interface
>>                IT8718F  Super I/O chip w/LPC interface
>> +             IT8720F  Super I/O chip w/LPC interface
>>                IT8726F  Super I/O chip w/LPC interface
>>                Sis950   A clone of the IT8705F
>>
>> @@ -50,7 +51,7 @@
>>
>>  #define DRVNAME "it87"
>>
>> -enum chips { it87, it8712, it8716, it8718 };
>> +enum chips { it87, it8712, it8716, it8718, it8720 };
>>
>>  static unsigned short force_id;
>>  module_param(force_id, ushort, 0);
>> @@ -111,6 +112,7 @@ superio_exit(void)
>>  #define IT8705F_DEVID 0x8705
>>  #define IT8716F_DEVID 0x8716
>>  #define IT8718F_DEVID 0x8718
>> +#define IT8720F_DEVID 0x8720
>>  #define IT8726F_DEVID 0x8726
>>  #define IT87_ACT_REG  0x30
>>  #define IT87_BASE_REG 0x60
>> @@ -278,7 +280,8 @@ static inline int has_16bit_fans(const s
>>         return (data->type = it87 && data->revision >= 0x03)
>>             || (data->type = it8712 && data->revision >= 0x08)
>>             || data->type = it8716
>> -           || data->type = it8718;
>> +           || data->type = it8718
>> +           || data->type = it8720;
>>  }
>>
>>  static int it87_probe(struct platform_device *pdev);
>> @@ -979,6 +982,9 @@ static int __init it87_find(unsigned sho
>>         case IT8726F_DEVID:
>>                 sio_data->type = it8716;
>>                 break;
>> +       case IT8720F_DEVID:
>> +               sio_data->type = it8720;
>> +               break;
>>         case IT8718F_DEVID:
>>                 sio_data->type = it8718;
>>                 break;
>> @@ -1012,7 +1018,7 @@ static int __init it87_find(unsigned sho
>>                 int reg;
>>
>>                 superio_select(GPIO);
>> -               if (chip_type = it8718)
>> +               if (chip_type = it8718 || chip_type = it8720)
>>                         sio_data->vid_value = superio_inb(IT87_SIO_VID_REG);
>>
>>                 reg = superio_inb(IT87_SIO_PINX2_REG);
>> @@ -1040,6 +1046,7 @@ static int __devinit it87_probe(struct p
>>                 "it8712",
>>                 "it8716",
>>                 "it8718",
>> +               "it8720",
>>         };
>>
>>         res = platform_get_resource(pdev, IORESOURCE_IO, 0);
>> @@ -1190,7 +1197,7 @@ static int __devinit it87_probe(struct p
>>         }
>>
>>         if (data->type = it8712 || data->type = it8716
>> -        || data->type = it8718) {
>> +        || data->type = it8718 || data->type = it8720) {
>>                 data->vrm = vid_which_vrm();
>>                 /* VID reading from Super-I/O config space if available */
>>                 data->vid = sio_data->vid_value;
>> @@ -1571,7 +1578,7 @@ static void __exit sm_it87_exit(void)
>>
>>  MODULE_AUTHOR("Chris Gauthron, "
>>               "Jean Delvare <khali@linux-fr.org>");
>> -MODULE_DESCRIPTION("IT8705F/8712F/8716F/8718F/8726F, SiS950 driver");
>> +MODULE_DESCRIPTION("IT8705F/8712F/8716F/8718F/8720F/8726F, SiS950 driver");
>>  module_param(update_vbat, bool, 0);
>>  MODULE_PARM_DESC(update_vbat, "Update vbat if set else return powerup value");
>>  module_param(fix_pwm_polarity, bool, 0);
>
> Changes look good to me.
>
> -Frank
>

Hi Frank,

Maybe I'm totally wrong, but since I'm not an expert, I'm fine with that ;)

So for handling the 5 fans, can't we "just" force the data->has_fan to
31 and update it87_read_value to read the right way for IT8720 with
it's fan# > 3? Not really sure to understand why we need to update
sysfs.

When I force has_fan to 5 fans, I get:

fan1:       3000 RPM  (min =    0 RPM)
fan2:          0 RPM  (min =    0 RPM)
fan3:       5973 RPM  (min =    0 RPM)
fan4:         -1 RPM  (min =   -1 RPM)
fan5:         -1 RPM  (min =   -1 RPM)


So can I just help him to read to pwm 4 and 5 correctly?

Regarding the resistors. should I publish the values? Or it's useless?

Thanks,

JM
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Frank Myhr]

Jean-Marc Spaggiari wrote:

>>> Regarding pwm4 and pwm5, I'm not really sure how to do 
>> Simplest and probably best to just ignore/don't worry about pwm4 and
>> pwm5 for now. Letting the user select pwm4 and pwm5 control will require
>> new sysfs attributes, there is currently no standard for these.
>> Something like:
>> pwm[4|5]_control
>>        which could take values [1|2|3]
>> But I haven't yet successfully used pwm control on fans 4 and 5 on my
>> boards, not yet sure it's possible, so it's probably premature to
>> consider new sysfs interfaces for potentially useless features.

To clear up some confusion (please see file sysfs-interface):
fan1_input thru fan5_input are measured fan rpms
pwm1 thru pwm5 are driving fan voltage pulse-width-modulation duty
cycles in range 0-255. (Some boards convert pwm to linearized dc voltage).


> When I force has_fan to 5 fans, I get:
> 
> fan1:       3000 RPM  (min =    0 RPM)
> fan2:          0 RPM  (min =    0 RPM)
> fan3:       5973 RPM  (min =    0 RPM)
> fan4:         -1 RPM  (min =   -1 RPM)
> fan5:         -1 RPM  (min =   -1 RPM)
> 
> So can I just help him to read to pwm 4 and 5 correctly?

The -1 values you're reporting for fan4 and fan5 come from
#define FAN16_FROM_REG(val) ((val)=0?-1:(val)=0xffff?0:1350000/((val)*2))

In other words, the 8720 reports "0", the above macro converts that to
-1. (I'm not entirely clear why this is done.)


> Regarding the resistors. should I publish the values? Or it's useless?

I think it would help at least other users of your board. Perhaps add it
 to Documentation/hwmon/it87 ?


-Frank

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Frank Myhr]

Jean-Marc Spaggiari wrote:

> Ok, so I will update the documentation when I will have the resistors value.

Great! Thank you.


> Regarding pwm, I'm able to read the fan speed for 3/3, but I'm able to
> modify it only for 2/3. the "power" fan seems to not reply to any
> command. Maybe it's not map correctly inside it87?

I think the mapping of it87 fan/pwm channel to motherboard fan header is
motherboard-specific. If your "power" fan is the fan inside your power
supply, then its speed is controlled by the power supply, not by the
it87. Typically the power supply will have a fan connector with only 2
wires, that can be plugged into a motherboard header to monitor (but not
control) rpm. Maybe I don't understand your situation?


> Regarding the patch, are you going to apply it? Or should I submit it somewhere?

Please submit it to this list when you are ready. Please see
Documentation/SubmittingPatches
for detailed instructions on submitting patches--the patch should be
formatted in a particular way, as should the email. Don't forget to
include "Signed-off-by:" (You can see examples in the other patches
submitted to this list.) I'd recommend sending a test email with the
patch to yourself first, to make sure your mailer isn't doing funky
things to it. I've managed to screw that up in various ways.

I've so far contributed a grand total of two (count 'em!) tiny patches,
one of which managed to trigger a regression that Jean kindly tracked
down and fixed. So I'm hardly an expert on the process. But generally
what I think happens is that after you've posted your patch to this
list, I or someone else will add an "Acked-by:" to it, Jean will add it
to his hwmon tree, which he will then submit to Linus.

Thanks for your work!,
Frank

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Jean Delvare]

Hi Jean-Marc,

Just a couple comments on top of what Frank already wrote and with
which I do agree.

On Fri, 3 Oct 2008 09:23:08 -0400, Jean-Marc Spaggiari wrote:
> Regarding pwm4 and pwm5, I'm not really sure how to do so, and I seen
> that some fans info was missing. So I will try to figure how to use it
> since I have 3 fans and only 2 are displayed.
> 
> fan1:       3013 RPM  (min =    0 RPM, div = 2)
> fan2:          0 RPM  (min =    0 RPM, div = 2)
> fan3:       5973 RPM  (min =    0 RPM, div = 2)

If fan2 is slow, try increasing fan2_div to 4 or even 8. But I'm a bit
surprised, if the IT8720F is similar to the IT8718F, then it should
have 16-bit fan tachometers and thus no fan_div registers.

> Last point, temperatures are slightly different from it8720 and k8temp.
> 
> temp1:       +41.0 °C  (low  =  -1.0 °C, high = +127.0 °C)  sensor = transistor
> temp2:       +34.0 °C  (low  =  -1.0 °C, high =  -3.0 °C)  sensor = transistor
> temp3:       +22.0 °C  (low  =  -5.0 °C, high = +127.0 °C)  sensor = transistor
> 
> k8temp-pci-00c3
> Adapter: PCI adapter
> Core0 Temp:  +43.0 °C
> Core1 Temp:  +37.0 °C
> 
> Has it87 only the motherboard temp?

I guess so, yes.

> In that case, why there is 3?

Why not? A motherboard is something relatively large, there's nothing
wrong with having several temperature sensors on it. For example you
can monitor the CPU socket, the north bridge and the south bridge. Or
virtually any point of the motherboard.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Looking for IT8720 datasheet.

[Jean Delvare]

On Fri, 03 Oct 2008 13:14:31 -0400, Frank Myhr wrote:
> Jean-Marc Spaggiari wrote:
> > When I force has_fan to 5 fans, I get:
> > 
> > fan1:       3000 RPM  (min =    0 RPM)
> > fan2:          0 RPM  (min =    0 RPM)
> > fan3:       5973 RPM  (min =    0 RPM)
> > fan4:         -1 RPM  (min =   -1 RPM)
> > fan5:         -1 RPM  (min =   -1 RPM)
> > 
> > So can I just help him to read to pwm 4 and 5 correctly?
> 
> The -1 values you're reporting for fan4 and fan5 come from
> #define FAN16_FROM_REG(val) ((val)=0?-1:(val)=0xffff?0:1350000/((val)*2))
> 
> In other words, the 8720 reports "0", the above macro converts that to
> -1. (I'm not entirely clear why this is done.)

That's a legacy from the good ol' times. Old drivers tend to report
missing fans, fan failures or impossible register values with a speed
of -1. It never made any sense to me and many drivers report this
condition as RPM = 0, with an optional fanN_fault file getting value 1
for detected fan failures.

We have no clear standard for this yet so in practice every driver is
free to report -1 or 0 for uncommon fan conditions.

> > Regarding the resistors. should I publish the values? Or it's useless?
> 
> I think it would help at least other users of your board. Perhaps add it
>  to Documentation/hwmon/it87 ?

Best is to write a configuration file for the motherboard in question
and publish it on lm-sensors.org/wiki.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors