From: Christoph Lameter <cl@linux-foundation.org>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, jeremy@goop.org, ebiederm@xmission.com,
travis@sgi.com, herbert@gondor.apana.org.au, xemul@openvz.org,
penberg@cs.helsinki.fi
Subject: Re: [patch 2/3] cpu alloc: Use in slub
Date: Fri, 03 Oct 2008 11:05:30 -0500 [thread overview]
Message-ID: <48E642CA.2050405@linux-foundation.org> (raw)
In-Reply-To: <48E63E76.1010702@cosmosbay.com>
Eric Dumazet wrote:
>
> Then maybe change MAX_NUMNODES to 0 or 1 to reflect
> node[] is dynamically sized ?
See kmem_cache_init(). It only allocates the used bytes. If you only have a
single nodes then only 1 pointer will be allocated.
#ifdef CONFIG_NUMA
kmem_size = offsetof(struct kmem_cache, node) +
nr_node_ids * sizeof(struct kmem_cache_node *);
#else
That does not work for the statically allocated kmalloc array though.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux-foundation.org>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, jeremy@goop.org, ebiederm@xmission.com,
travis@sgi.com, herbert@gondor.apana.org.au, xemul@openvz.org,
penberg@cs.helsinki.fi
Subject: Re: [patch 2/3] cpu alloc: Use in slub
Date: Fri, 03 Oct 2008 11:05:30 -0500 [thread overview]
Message-ID: <48E642CA.2050405@linux-foundation.org> (raw)
In-Reply-To: <48E63E76.1010702@cosmosbay.com>
Eric Dumazet wrote:
>
> Then maybe change MAX_NUMNODES to 0 or 1 to reflect
> node[] is dynamically sized ?
See kmem_cache_init(). It only allocates the used bytes. If you only have a
single nodes then only 1 pointer will be allocated.
#ifdef CONFIG_NUMA
kmem_size = offsetof(struct kmem_cache, node) +
nr_node_ids * sizeof(struct kmem_cache_node *);
#else
That does not work for the statically allocated kmalloc array though.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-03 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 15:24 [patch 0/3] Cpu alloc slub support V2: Replace percpu allocator in slub.c Christoph Lameter
2008-10-03 15:24 ` Christoph Lameter
2008-10-03 15:24 ` [patch 1/3] Increase default reserve percpu area Christoph Lameter
2008-10-03 15:24 ` Christoph Lameter
2008-10-03 15:24 ` [patch 2/3] cpu alloc: Use in slub Christoph Lameter
2008-10-03 15:24 ` Christoph Lameter
2008-10-03 15:47 ` Eric Dumazet
2008-10-03 15:47 ` Eric Dumazet
2008-10-03 16:05 ` Christoph Lameter [this message]
2008-10-03 16:05 ` Christoph Lameter
2008-10-03 15:24 ` [patch 3/3] cpu alloc: Remove slub fields Christoph Lameter
2008-10-03 15:24 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E642CA.2050405@linux-foundation.org \
--to=cl@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=ebiederm@xmission.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=travis@sgi.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.