From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: [NETFILTER]: Move extensions' arguments into compound structure (1/2)
Date: Sun, 05 Oct 2008 17:12:23 +0200 [thread overview]
Message-ID: <48E8D957.3000803@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0810051054460.21891@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Sunday 2008-10-05 10:52, Patrick McHardy wrote:
>> Reducing the overhead before merging will make me a lot more
>> comfortable accepting this patch without seeing any numbers
>> since its adding overhead to one of the hottest spots of ruleset
>> evaluation.
>>
> Ok just let me rebase all the stuff, and I'll send you something
> that goes on top of 8d51a66159a6fbc27342ee80e5b69910a679735e .
Thanks. As an added explanation - the benchmarking I did for nftables
indicated that we're somewhere between 50 and 110 cycles for a "usual"
rule on my x2. So its really easy to degrade performance significantly
by just requiring a few more cycles. The upside is that it works in both
directions :)
>>> Yup. When space is tight (and we only have like 74 chars to make it
>>> fit onto a screen, accounting for the git-log indent and one extra
>>> byte), it will have to do without the subsystem.
>> No, I'm adding it anyways and exceeding the limit is fine for
>> changelogs if it aids in readability. So please just add it so
>> I don't have to edit the descriptions every time.
>
> Aye, sir!
Thanks.
next prev parent reply other threads:[~2008-10-05 15:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 22:52 [NETFILTER]: Move extensions' arguments into compound structure (1/2) Jan Engelhardt
2008-10-03 22:54 ` [NETFILTER]: Move extensions' arguments into compound structure (2/2) Jan Engelhardt
2008-10-04 13:48 ` [NETFILTER]: Move extensions' arguments into compound structure (1/2) Jan Engelhardt
2008-10-05 14:30 ` Patrick McHardy
2008-10-05 14:40 ` Jan Engelhardt
2008-10-05 14:52 ` Patrick McHardy
2008-10-05 14:55 ` Jan Engelhardt
2008-10-05 15:12 ` Patrick McHardy [this message]
2008-10-05 15:24 ` Jan Engelhardt
2008-10-05 15:31 ` Patrick McHardy
2008-10-05 16:19 ` Jan Engelhardt
2008-10-05 16:26 ` Patrick McHardy
2008-10-05 16:33 ` Jan Engelhardt
2008-10-05 16:36 ` Patrick McHardy
2008-10-05 20:14 ` Jan Engelhardt
2008-10-06 10:18 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E8D957.3000803@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.