* [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required
@ 2008-10-06 20:51 Hervé Poussineau
2008-10-13 21:15 ` Aurelien Jarno
2008-10-14 8:53 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: Hervé Poussineau @ 2008-10-06 20:51 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
Hi,
In TLB Load and TLB Store exceptions, we should look at the Status
register to know in which mode we are.
Existing code checks upper bits of the address, which is totally wrong.
Hervé
[-- Attachment #2: fix_xtlb_handler_call.diff --]
[-- Type: plain/text, Size: 1571 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required
2008-10-06 20:51 [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required Hervé Poussineau
@ 2008-10-13 21:15 ` Aurelien Jarno
2008-10-14 8:53 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2008-10-13 21:15 UTC (permalink / raw)
To: qemu-devel
On Mon, Oct 06, 2008 at 10:51:07PM +0200, Hervé Poussineau wrote:
> Hi,
>
> In TLB Load and TLB Store exceptions, we should look at the Status
> register to know in which mode we are.
> Existing code checks upper bits of the address, which is totally wrong.
>
This breaks the boot of a 64-bit linux kernel.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required
2008-10-06 20:51 [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required Hervé Poussineau
2008-10-13 21:15 ` Aurelien Jarno
@ 2008-10-14 8:53 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2008-10-14 8:53 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-devel
On Mon, Oct 06, 2008 at 10:51:07PM +0200, Hervé Poussineau wrote:
> Hi,
>
> In TLB Load and TLB Store exceptions, we should look at the Status
> register to know in which mode we are.
> Existing code checks upper bits of the address, which is totally wrong.
>
You are wrong. The current code is correct.
If you look at the "MIPS64 Privileged Resource Architecture document",
table "4.5 Access Control as a Function of Address and Operating Mode"
(page 17 in my edition), you will see that the refill vector actually
depends on the address and not on the current mode.
That's why your patch doesn't allow a 64-bit linux kernel to boot.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-14 8:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-06 20:51 [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required Hervé Poussineau
2008-10-13 21:15 ` Aurelien Jarno
2008-10-14 8:53 ` Aurelien Jarno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.