[Fwd: [PATCH 2.4]: ip6t_{hbh,dst}: Rejects not-strict mode on rule insersion]

[Fwd: [PATCH 2.4]: ip6t_{hbh,dst}: Rejects not-strict mode on rule insersion]

[Patrick McHardy]

Hi Willy,

This patch from Yasuyuki fixes a problem in the hbh/dst matches which
is currently hidden by broken userspace, but will be exposed once
we've fixed userspace. Unfortunately neither of us has a working
2.4 environment, so all I can do is forward the patch. The upstream
commit ID is 8ca31ce52.

Please apply as you see fit. Thanks!

-------- Original Message --------
Subject: [PATCH 2.4]: ip6t_{hbh,dst}: Rejects not-strict mode on rule 
insersion
Date: Mon, 08 Sep 2008 15:32:34 +0900 (JST)
From: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
To: kaber@trash.net
CC: netfilter-devel@vger.kernel.org
References: <20080908.151349.84890575.kozakai@isl.rdc.toshiba.co.jp>


This is for 2.4 kernel (build test with 2.4.37-rc1, I have no environment
to run 2.4, sorry).



[NETFILTER]: ip6t_{hbh,dst}: Rejects not-strict mode on rule insertion

The current code ignores rules for internal options in HBH/DST options
header in packet processing if 'Not strict' mode is specified (which is not
implemented). Clearly it is not expected by user.

Kernel should reject HBH/DST rule insertion with 'Not strict' mode
in the first place.

Signed-off-by: Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>
---
  net/ipv6/netfilter/ip6t_dst.c |    6 ++++--
  net/ipv6/netfilter/ip6t_hbh.c |    6 ++++--
  2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/net/ipv6/netfilter/ip6t_dst.c b/net/ipv6/netfilter/ip6t_dst.c
index 65213e9..35ba724 100644
--- a/net/ipv6/netfilter/ip6t_dst.c
+++ b/net/ipv6/netfilter/ip6t_dst.c
@@ -172,8 +172,6 @@ match(const struct sk_buff *skb,
         hdrlen -= 2;
         if ( !(optinfo->flags & IP6T_OPTS_OPTS) ){
  	       return ret;
-	} else if (optinfo->flags & IP6T_OPTS_NSTRICT) {
-		DEBUGP("Not strict - not implemented");
  	} else {
  		DEBUGP("Strict ");
  		DEBUGP("#%d ",optinfo->optsnr);
@@ -253,6 +251,10 @@ checkentry(const char *tablename,
                        optsinfo->invflags);
                return 0;
         }
+	if (optsinfo->flags & IP6T_OPTS_NSTRICT) {
+		DEBUGP("ip6t_opts: Not strict - not implemented");
+		return 0;
+	}

         return 1;
  }
diff --git a/net/ipv6/netfilter/ip6t_hbh.c b/net/ipv6/netfilter/ip6t_hbh.c
index b37e4ce..720cb8d 100644
--- a/net/ipv6/netfilter/ip6t_hbh.c
+++ b/net/ipv6/netfilter/ip6t_hbh.c
@@ -172,8 +172,6 @@ match(const struct sk_buff *skb,
         hdrlen -= 2;
         if ( !(optinfo->flags & IP6T_OPTS_OPTS) ){
  	       return ret;
-	} else if (optinfo->flags & IP6T_OPTS_NSTRICT) {
-		DEBUGP("Not strict - not implemented");
  	} else {
  		DEBUGP("Strict ");
  		DEBUGP("#%d ",optinfo->optsnr);
@@ -253,6 +251,10 @@ checkentry(const char *tablename,
                        optsinfo->invflags);
                return 0;
         }
+	if (optsinfo->flags & IP6T_OPTS_NSTRICT) {
+		DEBUGP("ip6t_opts: Not strict - not implemented");
+		return 0;
+	}

         return 1;
  }
-- 
1.5.3.6

--
To unsubscribe from this list: send the line "unsubscribe 
netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Fwd: [PATCH 2.4]: ip6t_{hbh,dst}: Rejects not-strict mode on rule insersion]

[Willy Tarreau]

Hi Patrick,

On Wed, Oct 08, 2008 at 02:32:34PM +0200, Patrick McHardy wrote:
> Hi Willy,
> 
> This patch from Yasuyuki fixes a problem in the hbh/dst matches which
> is currently hidden by broken userspace, but will be exposed once
> we've fixed userspace. Unfortunately neither of us has a working
> 2.4 environment, so all I can do is forward the patch. The upstream
> commit ID is 8ca31ce52.

OK. I still have working 2.4 + IPv6, so if there is any reproducer, I can
test the fix. Otherwise, I'll apply it, as it seems pretty straight-forward
for anyone who doesn't want to precisely understand what it fixes :-)

Thanks,
Willy

Re: [Fwd: [PATCH 2.4]: ip6t_{hbh,dst}: Rejects not-strict mode on rule insersion]

[Patrick McHardy]

Willy Tarreau wrote:
> Hi Patrick,
> 
> On Wed, Oct 08, 2008 at 02:32:34PM +0200, Patrick McHardy wrote:
>> Hi Willy,
>>
>> This patch from Yasuyuki fixes a problem in the hbh/dst matches which
>> is currently hidden by broken userspace, but will be exposed once
>> we've fixed userspace. Unfortunately neither of us has a working
>> 2.4 environment, so all I can do is forward the patch. The upstream
>> commit ID is 8ca31ce52.
> 
> OK. I still have working 2.4 + IPv6, so if there is any reproducer, I can
> test the fix. Otherwise, I'll apply it, as it seems pretty straight-forward
> for anyone who doesn't want to precisely understand what it fixes :-)

I guess it can't be tested right now because of the userspace problem,
but it really is pretty straight forward :)