All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: Expectation not quite up to where I want it
Date: Wed, 08 Oct 2008 15:07:26 +0200	[thread overview]
Message-ID: <48ECB08E.5070909@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0810041816150.21891@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> 
> I am not quite sure whether it is possible to even set up an
> expectation when ctstate(ct) == IP_CT_NEW, is it? 

It is - TFTP, SIP and netbios_ns are doing this.

> Fact is, this piece
> of code segfaults on me right away in nf_ct_expect_related(),
> possibly because exp->master or so is NULL, causing bad things when
> issuing nfct_help(exp->master) in nf_ct_expect_related.
> Any hints?
> 
>     →   nf_ct_expect_init(exp, NF_CT_EXPECT_CLASS_DEFAULT, PF_INET6, 
>     →       →   (const union nf_inet_addr *)&iph->daddr, 
>     →       →   (const union nf_inet_addr *)&iph->saddr, 
>     →       →   IPPROTO_MH, NULL, &man); 
>     →   printk(KERN_INFO "expectation set up\n"); 
>     →   nf_ct_dump_tuple(&exp->tuple); 
>     →   if (nf_ct_expect_related(exp) != 0) 
>     →       →   printk(KERN_INFO "hm\n"); 
>     →   nf_ct_expect_put(exp); /* yes no ? / 

                                     ^ yes

The part above is correct, the bug must be elsewhere.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2008-10-08 13:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-04 22:36 Expectation not quite up to where I want it Jan Engelhardt
2008-10-08 13:07 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48ECB08E.5070909@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.