Expectation not quite up to where I want it

Expectation not quite up to where I want it

[Jan Engelhardt]

I am not quite sure whether it is possible to even set up an
expectation when ctstate(ct) == IP_CT_NEW, is it? Fact is, this piece
of code segfaults on me right away in nf_ct_expect_related(),
possibly because exp->master or so is NULL, causing bad things when
issuing nfct_help(exp->master) in nf_ct_expect_related.
Any hints?

    →   nf_ct_expect_init(exp, NF_CT_EXPECT_CLASS_DEFAULT, PF_INET6, 
    →       →   (const union nf_inet_addr *)&iph->daddr, 
    →       →   (const union nf_inet_addr *)&iph->saddr, 
    →       →   IPPROTO_MH, NULL, &man); 
    →   printk(KERN_INFO "expectation set up\n"); 
    →   nf_ct_dump_tuple(&exp->tuple); 
    →   if (nf_ct_expect_related(exp) != 0) 
    →       →   printk(KERN_INFO "hm\n"); 
    →   nf_ct_expect_put(exp); /* yes no ? /
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Expectation not quite up to where I want it

[Patrick McHardy]

Jan Engelhardt wrote:
> 
> I am not quite sure whether it is possible to even set up an
> expectation when ctstate(ct) == IP_CT_NEW, is it? 

It is - TFTP, SIP and netbios_ns are doing this.

> Fact is, this piece
> of code segfaults on me right away in nf_ct_expect_related(),
> possibly because exp->master or so is NULL, causing bad things when
> issuing nfct_help(exp->master) in nf_ct_expect_related.
> Any hints?
> 
>     →   nf_ct_expect_init(exp, NF_CT_EXPECT_CLASS_DEFAULT, PF_INET6, 
>     →       →   (const union nf_inet_addr *)&iph->daddr, 
>     →       →   (const union nf_inet_addr *)&iph->saddr, 
>     →       →   IPPROTO_MH, NULL, &man); 
>     →   printk(KERN_INFO "expectation set up\n"); 
>     →   nf_ct_dump_tuple(&exp->tuple); 
>     →   if (nf_ct_expect_related(exp) != 0) 
>     →       →   printk(KERN_INFO "hm\n"); 
>     →   nf_ct_expect_put(exp); /* yes no ? / 

                                     ^ yes

The part above is correct, the bug must be elsewhere.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html