All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fujitsu-laptop: fix section mismatch warning
@ 2008-10-08 21:22 Randy Dunlap
  2008-10-09  0:25 ` Len Brown
  2008-10-09  1:03 ` Jonathan Woithe
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2008-10-08 21:22 UTC (permalink / raw)
  To: linux-acpi, lenb, akpm; +Cc: Jonathan Woithe

From: Randy Dunlap <randy.dunlap@oracle.com>

Could fix a bug in a hotplug add scenario.

WARNING: drivers/misc/fujitsu-laptop.o(.text+0xbde): Section mismatch in reference from the function acpi_fujitsu_add() to the variable .init.data:fujitsu_dmi_table
The function acpi_fujitsu_add() references
the variable __initdata fujitsu_dmi_table.
This is often because acpi_fujitsu_add lacks a __initdata 
annotation or the annotation of fujitsu_dmi_table is wrong.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
---
 drivers/misc/fujitsu-laptop.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lin2627-r9g1-sections.orig/drivers/misc/fujitsu-laptop.c
+++ lin2627-r9g1-sections/drivers/misc/fujitsu-laptop.c
@@ -455,7 +455,7 @@ static int dmi_check_cb_s6410(const stru
 	return 0;
 }
 
-static struct dmi_system_id __initdata fujitsu_dmi_table[] = {
+static struct dmi_system_id fujitsu_dmi_table[] = {
 	{
 	 .ident = "Fujitsu Siemens",
 	 .matches = {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fujitsu-laptop: fix section mismatch warning
  2008-10-08 21:22 [PATCH] fujitsu-laptop: fix section mismatch warning Randy Dunlap
@ 2008-10-09  0:25 ` Len Brown
  2008-10-09  1:03 ` Jonathan Woithe
  1 sibling, 0 replies; 3+ messages in thread
From: Len Brown @ 2008-10-09  0:25 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-acpi, akpm, Jonathan Woithe

applied to acpi-test.

thanks,
-Len

On Wed, 8 Oct 2008, Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Could fix a bug in a hotplug add scenario.
> 
> WARNING: drivers/misc/fujitsu-laptop.o(.text+0xbde): Section mismatch in reference from the function acpi_fujitsu_add() to the variable .init.data:fujitsu_dmi_table
> The function acpi_fujitsu_add() references
> the variable __initdata fujitsu_dmi_table.
> This is often because acpi_fujitsu_add lacks a __initdata 
> annotation or the annotation of fujitsu_dmi_table is wrong.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
> ---
>  drivers/misc/fujitsu-laptop.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lin2627-r9g1-sections.orig/drivers/misc/fujitsu-laptop.c
> +++ lin2627-r9g1-sections/drivers/misc/fujitsu-laptop.c
> @@ -455,7 +455,7 @@ static int dmi_check_cb_s6410(const stru
>  	return 0;
>  }
>  
> -static struct dmi_system_id __initdata fujitsu_dmi_table[] = {
> +static struct dmi_system_id fujitsu_dmi_table[] = {
>  	{
>  	 .ident = "Fujitsu Siemens",
>  	 .matches = {
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fujitsu-laptop: fix section mismatch warning
  2008-10-08 21:22 [PATCH] fujitsu-laptop: fix section mismatch warning Randy Dunlap
  2008-10-09  0:25 ` Len Brown
@ 2008-10-09  1:03 ` Jonathan Woithe
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Woithe @ 2008-10-09  1:03 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-acpi, lenb, akpm, Jonathan Woithe

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Could fix a bug in a hotplug add scenario.
> 
> WARNING: drivers/misc/fujitsu-laptop.o(.text+0xbde): Section mismatch in reference from the function acpi_fujitsu_add() to the variable .init.data:fujitsu_dmi_table
> The function acpi_fujitsu_add() references
> the variable __initdata fujitsu_dmi_table.
> This is often because acpi_fujitsu_add lacks a __initdata 
> annotation or the annotation of fujitsu_dmi_table is wrong.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
> ---
>  drivers/misc/fujitsu-laptop.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lin2627-r9g1-sections.orig/drivers/misc/fujitsu-laptop.c
> +++ lin2627-r9g1-sections/drivers/misc/fujitsu-laptop.c
> @@ -455,7 +455,7 @@ static int dmi_check_cb_s6410(const stru
>  	return 0;
>  }
>  
> -static struct dmi_system_id __initdata fujitsu_dmi_table[] = {
> +static struct dmi_system_id fujitsu_dmi_table[] = {
>  	{
>  	 .ident = "Fujitsu Siemens",
>  	 .matches = {

Ack.

Regards
  jonathan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-10-09  1:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-08 21:22 [PATCH] fujitsu-laptop: fix section mismatch warning Randy Dunlap
2008-10-09  0:25 ` Len Brown
2008-10-09  1:03 ` Jonathan Woithe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.