All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm: Fix Converting PTE to PFN
@ 2008-10-09  7:04 Yosuke Iwamatsu
  0 siblings, 0 replies; only message in thread
From: Yosuke Iwamatsu @ 2008-10-09  7:04 UTC (permalink / raw)
  To: xen-devel

On x86_64 system, (pte >> PAGE_SHIFT) is not always equal to page frame
number because high bits (63:52) of pte may be used as flags. This patch
corrects the conversion and errors as below disappear when applied.
    (XEN) mm.c:3074:d0 PTE entry 200000a2ec6167 for address a1f09958
    doesn't match frame a2ec6

Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>

diff -r e66cecb66b1e xen/arch/x86/mm.c
--- a/xen/arch/x86/mm.c	Wed Oct 08 14:00:58 2008 +0100
+++ b/xen/arch/x86/mm.c	Thu Oct 09 14:14:13 2008 +0900
@@ -3067,7 +3067,7 @@ static int destroy_grant_pte_mapping(
     ol1e = *(l1_pgentry_t *)va;

     /* Check that the virtual address supplied is actually mapped to
frame. */
-    if ( unlikely((l1e_get_intpte(ol1e) >> PAGE_SHIFT) != frame) )
+    if ( unlikely(l1e_get_pfn(ol1e) != frame) )
     {
         page_unlock(page);
         MEM_LOG("PTE entry %lx for address %"PRIx64" doesn't match
frame %lx",

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-10-09  7:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-09  7:04 [PATCH] mm: Fix Converting PTE to PFN Yosuke Iwamatsu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.